You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 13:07:49 UTC

[PR] test(alert): deepen AlertSilenceController list and delete coverage [rocketmq-dashboard]

yyqdbngt opened a new pull request, #3333:
URL: https://github.com/apache/rocketmq-dashboard/pull/3333

   ## Summary
   
   Extends the existing `@WebMvcTest` `AlertSilenceControllerTest` (2 to 4 tests) to pin down the remaining silence endpoints.
   
   Added cases:
   - `GET /api/alert-silences` returns the full silence list from the service;
   - `DELETE /api/alert-silences/{id}` parses the path id and delegates to the service.
   
   ## Why
   
   The suite covered the paged list and recurring-create endpoints only; the unpaged list and delete flows had no coverage.
   
   ## Testing
   
   `mvn -B test -Dtest=AlertSilenceControllerTest` — 4/4 pass; checkstyle (validate) clean.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(alert): deepen AlertSilenceController list and delete coverage [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3333: test(alert): deepen AlertSilenceController list and delete coverage
URL: https://github.com/apache/rocketmq-dashboard/pull/3333


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org