You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Hector Acosta (Code Review)" <ge...@cloudera.org> on 2019/03/26 21:13:38 UTC
[native-toolchain-CR] Install newer git version in centos 6.6
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12862
Change subject: Install newer git version in centos 6.6
......................................................................
Install newer git version in centos 6.6
Centos 6.6 contains a git version that doesn't work over dumb-http. To
fix it we include a new Centos-Vault repo file with disabled
repositories and explicitly install git from centos 6.9, which works.
Change-Id: I66549477ec9378faeda46a98cf6556a3207979eb
---
M docker/all/assert-dependencies-present.py
A docker/redhat/Centos6-Vault.repo
M docker/redhat6.df
3 files changed, 389 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/62/12862/1
--
To view, visit http://gerrit.cloudera.org:8080/12862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I66549477ec9378faeda46a98cf6556a3207979eb
Gerrit-Change-Number: 12862
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
[native-toolchain-CR] Install newer nss version in centos 6.6
Posted by "Hector Acosta (Code Review)" <ge...@cloudera.org>.
Hector Acosta has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12862 )
Change subject: Install newer nss version in centos 6.6
......................................................................
Install newer nss version in centos 6.6
Centos 6.6 ships with an nss version that can't clone from github. To
fix it we include a new Centos-Vault repo file with disabled
repositories and explicitly install nss from centos 6.9, which works.
Change-Id: I66549477ec9378faeda46a98cf6556a3207979eb
---
M docker/all/assert-dependencies-present.py
A docker/redhat/Centos6-Vault.repo
M docker/redhat6.df
3 files changed, 23 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/62/12862/3
--
To view, visit http://gerrit.cloudera.org:8080/12862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I66549477ec9378faeda46a98cf6556a3207979eb
Gerrit-Change-Number: 12862
Gerrit-PatchSet: 3
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
[native-toolchain-CR] Install newer nss version in centos 6.6
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12862 )
Change subject: Install newer nss version in centos 6.6
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Looks good, just a couple of suggestions for comments.
http://gerrit.cloudera.org:8080/#/c/12862/3/docker/all/assert-dependencies-present.py
File docker/all/assert-dependencies-present.py:
http://gerrit.cloudera.org:8080/#/c/12862/3/docker/all/assert-dependencies-present.py@122
PS3, Line 122: clone
Similarly, I'd suggest mentioning HTTPS explicitly here. (the git://.... protocol would always work but it is insecure, so we wouldn't want to use that).
http://gerrit.cloudera.org:8080/#/c/12862/3/docker/redhat6.df
File docker/redhat6.df:
http://gerrit.cloudera.org:8080/#/c/12862/3/docker/redhat6.df@51
PS3, Line 51: can't clone from
: # github.
Maybe phrase this a bit more explicitly: the real problem is that Github now enforces TLSv1.2, which the CentOS 6.6 version of NSS cannot handle?
--
To view, visit http://gerrit.cloudera.org:8080/12862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66549477ec9378faeda46a98cf6556a3207979eb
Gerrit-Change-Number: 12862
Gerrit-PatchSet: 3
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 Mar 2019 21:19:09 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] Install newer nss version in centos 6.6
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12862 )
Change subject: Install newer nss version in centos 6.6
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66549477ec9378faeda46a98cf6556a3207979eb
Gerrit-Change-Number: 12862
Gerrit-PatchSet: 4
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Apr 2019 16:18:03 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Install newer nss version in centos 6.6
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12862 )
Change subject: Install newer nss version in centos 6.6
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12862/2/docker/redhat6.df
File docker/redhat6.df:
http://gerrit.cloudera.org:8080/#/c/12862/2/docker/redhat6.df@53
PS2, Line 53: --enablerepo=C6.9-base nss
This worries me: my concern is that this creates a Frankenbuild with some parts sourced from 6.6, some others from 6.9.
Why not just commit to using CentOS 6.8 as the minimum supported version?
1. Git in CentOS 6.8 can clone the Kudu repo cleanly, no tweaks are needed for Git and/or NSS
2. CentOS 6.8 was released almost 3 years ago (see https://lists.centos.org/pipermail/centos-announce/2016-May/021895.html).
I think we can expect anyone developing for Apache Impala to have an OS which at least as recent as 6.8.
http://gerrit.cloudera.org:8080/#/c/12862/2/docker/redhat6.df@53
PS2, Line 53: git clone https://github.com/apache/kudu
Even if you still want to check for the proper level of TLS support, (although I would strongly recommend going to CentOS 6.8) this is quite excessive: cloning the repo would pull in at least 56 MB of content and leave it in the Docker image. A much more lightweight check could be to run
$ git ls-remote --heads https://github.com/apache/kudu
which passes/fails the same way and copies nothing into the image.
--
To view, visit http://gerrit.cloudera.org:8080/12862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66549477ec9378faeda46a98cf6556a3207979eb
Gerrit-Change-Number: 12862
Gerrit-PatchSet: 2
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Mar 2019 14:29:06 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] Install newer git version in centos 6.6
Posted by "Hector Acosta (Code Review)" <ge...@cloudera.org>.
Hector Acosta has abandoned this change. ( http://gerrit.cloudera.org:8080/12862 )
Change subject: Install newer git version in centos 6.6
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/12862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I66549477ec9378faeda46a98cf6556a3207979eb
Gerrit-Change-Number: 12862
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
[native-toolchain-CR] Install newer nss version in centos 6.6
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12862 )
Change subject: Install newer nss version in centos 6.6
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66549477ec9378faeda46a98cf6556a3207979eb
Gerrit-Change-Number: 12862
Gerrit-PatchSet: 4
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Apr 2019 16:18:08 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Install newer nss version in centos 6.6
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12862 )
Change subject: Install newer nss version in centos 6.6
......................................................................
Install newer nss version in centos 6.6
Centos 6.6 ships with an nss version that can't clone from github. To
fix it we include a new Centos-Vault repo file with disabled
repositories and explicitly install nss from centos 6.9, which works.
Change-Id: I66549477ec9378faeda46a98cf6556a3207979eb
Reviewed-on: http://gerrit.cloudera.org:8080/12862
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M docker/all/assert-dependencies-present.py
A docker/redhat/Centos6-Vault.repo
M docker/redhat6.df
3 files changed, 23 insertions(+), 1 deletion(-)
Approvals:
Tim Armstrong: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I66549477ec9378faeda46a98cf6556a3207979eb
Gerrit-Change-Number: 12862
Gerrit-PatchSet: 5
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] Install newer nss version in centos 6.6
Posted by "Hector Acosta (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12862
to look at the new patch set (#4).
Change subject: Install newer nss version in centos 6.6
......................................................................
Install newer nss version in centos 6.6
Centos 6.6 ships with an nss version that can't clone from github. To
fix it we include a new Centos-Vault repo file with disabled
repositories and explicitly install nss from centos 6.9, which works.
Change-Id: I66549477ec9378faeda46a98cf6556a3207979eb
---
M docker/all/assert-dependencies-present.py
A docker/redhat/Centos6-Vault.repo
M docker/redhat6.df
3 files changed, 23 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/62/12862/4
--
To view, visit http://gerrit.cloudera.org:8080/12862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I66549477ec9378faeda46a98cf6556a3207979eb
Gerrit-Change-Number: 12862
Gerrit-PatchSet: 4
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
[native-toolchain-CR] Install newer nss version in centos 6.6
Posted by "Hector Acosta (Code Review)" <ge...@cloudera.org>.
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12862 )
Change subject: Install newer nss version in centos 6.6
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12862/2/docker/redhat6.df
File docker/redhat6.df:
http://gerrit.cloudera.org:8080/#/c/12862/2/docker/redhat6.df@53
PS2, Line 53: --enablerepo=C6.9-base nss
> This worries me: my concern is that this creates a Frankenbuild with some p
We've agreed that keeping the 6.6 base is the least invasive path.
--
To view, visit http://gerrit.cloudera.org:8080/12862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66549477ec9378faeda46a98cf6556a3207979eb
Gerrit-Change-Number: 12862
Gerrit-PatchSet: 2
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 Mar 2019 03:18:26 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] Install newer git version in centos 6.6
Posted by "Hector Acosta (Code Review)" <ge...@cloudera.org>.
Hector Acosta has restored this change. ( http://gerrit.cloudera.org:8080/12862 )
Change subject: Install newer git version in centos 6.6
......................................................................
Restored
--
To view, visit http://gerrit.cloudera.org:8080/12862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: restore
Gerrit-Change-Id: I66549477ec9378faeda46a98cf6556a3207979eb
Gerrit-Change-Number: 12862
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
[native-toolchain-CR] Install newer nss version in centos 6.6
Posted by "Hector Acosta (Code Review)" <ge...@cloudera.org>.
Hector Acosta has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12862 )
Change subject: Install newer nss version in centos 6.6
......................................................................
Install newer nss version in centos 6.6
Centos 6.6 ships with an nss version that can't clone from github. To
fix it we include a new Centos-Vault repo file with disabled
repositories and explicitly install nss from centos 6.9, which works.
Change-Id: I66549477ec9378faeda46a98cf6556a3207979eb
---
M docker/all/assert-dependencies-present.py
A docker/redhat/Centos6-Vault.repo
M docker/redhat6.df
3 files changed, 390 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/62/12862/2
--
To view, visit http://gerrit.cloudera.org:8080/12862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I66549477ec9378faeda46a98cf6556a3207979eb
Gerrit-Change-Number: 12862
Gerrit-PatchSet: 2
Gerrit-Owner: Hector Acosta <he...@cloudera.com>