You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Brandon Williams (JIRA)" <ji...@apache.org> on 2010/02/22 19:16:28 UTC

[jira] Created: (CASSANDRA-820) add key counts to stress.py

add key counts to stress.py
---------------------------

                 Key: CASSANDRA-820
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-820
             Project: Cassandra
          Issue Type: Improvement
            Reporter: Brandon Williams
            Assignee: Brandon Williams


stress.py currently counts interval op rates, but in the case of range slices, interval key rates should also be tracked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-820) add key counts to stress.py

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Williams updated CASSANDRA-820:
---------------------------------------

    Priority: Minor  (was: Major)

> add key counts to stress.py
> ---------------------------
>
>                 Key: CASSANDRA-820
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-820
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>         Attachments: 820.patch
>
>
> stress.py currently counts interval op rates, but in the case of range slices, interval key rates should also be tracked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-820) add key counts to stress.py

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836874#action_12836874 ] 

Brandon Williams commented on CASSANDRA-820:
--------------------------------------------

Discussed with Jonathan on irc, and we decided to keep this as-is since the key count can be falsely inflated via the op count when the last range slice returns less than the specified count.

> add key counts to stress.py
> ---------------------------
>
>                 Key: CASSANDRA-820
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-820
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>         Attachments: 820.patch
>
>
> stress.py currently counts interval op rates, but in the case of range slices, interval key rates should also be tracked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-820) add key counts to stress.py

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837773#action_12837773 ] 

Hudson commented on CASSANDRA-820:
----------------------------------

Integrated in Cassandra #364 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/364/])
    add key throughput as well as op throughput, for the benefit of get_range_slice.  patch by Brandon Williams; reviewed by jbellis for 


> add key counts to stress.py
> ---------------------------
>
>                 Key: CASSANDRA-820
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-820
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Contrib
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 820.patch
>
>
> stress.py currently counts interval op rates, but in the case of range slices, interval key rates should also be tracked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-820) add key counts to stress.py

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836860#action_12836860 ] 

Brandon Williams commented on CASSANDRA-820:
--------------------------------------------

Yes, now that you mention it, that makes the most sense.  I'll rework the patch to remove op counts.

> add key counts to stress.py
> ---------------------------
>
>                 Key: CASSANDRA-820
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-820
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>         Attachments: 820.patch
>
>
> stress.py currently counts interval op rates, but in the case of range slices, interval key rates should also be tracked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (CASSANDRA-820) add key counts to stress.py

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836770#action_12836770 ] 

Brandon Williams edited comment on CASSANDRA-820 at 2/22/10 6:24 PM:
---------------------------------------------------------------------

It's worth noting that during reads/inserts you would expect the op rate to be equal to the key rate, but this isn't always the case due the concurrent processes involved, however they should always be fairly close.  Key rate has no real meaning during these operations anyway, it is only included so that that the output format is consistent between all the operations.

      was (Author: brandon.williams):
    It's worth noting that during reads/inserts where you would expect the op rate to be equal to the key rate, but this isn't always the case due the concurrent processes involved, however they should always be fairly close.  Key rate has no real meaning during these operations anyway, it is only included so that that the output format is consistent between all the operations.
  
> add key counts to stress.py
> ---------------------------
>
>                 Key: CASSANDRA-820
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-820
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>         Attachments: 820.patch
>
>
> stress.py currently counts interval op rates, but in the case of range slices, interval key rates should also be tracked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-820) add key counts to stress.py

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836770#action_12836770 ] 

Brandon Williams commented on CASSANDRA-820:
--------------------------------------------

It's worth noting that during reads/inserts where you would expect the op rate to be equal to the key rate, but this isn't always the case due the concurrent processes involved, however they should always be fairly close.  Key rate has no real meaning during these operations anyway, it is only included so that that the output format is consistent between all the operations.

> add key counts to stress.py
> ---------------------------
>
>                 Key: CASSANDRA-820
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-820
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>         Attachments: 820.patch
>
>
> stress.py currently counts interval op rates, but in the case of range slices, interval key rates should also be tracked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-820) add key counts to stress.py

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-820:
-------------------------------------

    Component/s: Contrib

> add key counts to stress.py
> ---------------------------
>
>                 Key: CASSANDRA-820
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-820
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Contrib
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 820.patch
>
>
> stress.py currently counts interval op rates, but in the case of range slices, interval key rates should also be tracked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-820) add key counts to stress.py

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Williams updated CASSANDRA-820:
---------------------------------------

    Attachment: 820.patch

This patch adds an interval_key_rate to all operations, and fixes a small bug in rangeslice when the length of the result is one.

> add key counts to stress.py
> ---------------------------
>
>                 Key: CASSANDRA-820
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-820
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>         Attachments: 820.patch
>
>
> stress.py currently counts interval op rates, but in the case of range slices, interval key rates should also be tracked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-820) add key counts to stress.py

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836842#action_12836842 ] 

Jonathan Ellis commented on CASSANDRA-820:
------------------------------------------

somehow i thought we were only outputting key rates.  oops.

i'd be fine w/ leaving it just outputting op rates...  now that the code is written, what do you think? :)

> add key counts to stress.py
> ---------------------------
>
>                 Key: CASSANDRA-820
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-820
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>         Attachments: 820.patch
>
>
> stress.py currently counts interval op rates, but in the case of range slices, interval key rates should also be tracked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-820) add key counts to stress.py

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836865#action_12836865 ] 

Jonathan Ellis commented on CASSANDRA-820:
------------------------------------------

i'm saying it was fine the way it was pre-patch. :)

> add key counts to stress.py
> ---------------------------
>
>                 Key: CASSANDRA-820
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-820
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>         Attachments: 820.patch
>
>
> stress.py currently counts interval op rates, but in the case of range slices, interval key rates should also be tracked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (CASSANDRA-820) add key counts to stress.py

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836874#action_12836874 ] 

Brandon Williams edited comment on CASSANDRA-820 at 2/22/10 8:15 PM:
---------------------------------------------------------------------

Discussed with Jonathan on irc, and we decided to keep this patch since the key count can be falsely inflated via the op count when the last range slice returns less than the specified count.

      was (Author: brandon.williams):
    Discussed with Jonathan on irc, and we decided to keep this as-is since the key count can be falsely inflated via the op count when the last range slice returns less than the specified count.
  
> add key counts to stress.py
> ---------------------------
>
>                 Key: CASSANDRA-820
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-820
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>         Attachments: 820.patch
>
>
> stress.py currently counts interval op rates, but in the case of range slices, interval key rates should also be tracked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.