You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Uri Shachar (JIRA)" <ji...@apache.org> on 2013/02/21 12:22:14 UTC

[jira] [Updated] (TS-1674) TSStatIntDecrement is broken

     [ https://issues.apache.org/jira/browse/TS-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uri Shachar updated TS-1674:
----------------------------

    Attachment: remove_per_thread_stats.patch

Adding a patch that removes per-thread stats (it isn't very clean)
                
> TSStatIntDecrement is broken
> ----------------------------
>
>                 Key: TS-1674
>                 URL: https://issues.apache.org/jira/browse/TS-1674
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: TS API
>            Reporter: Brian Geffon
>            Assignee: Brian Geffon
>             Fix For: 3.3.1
>
>         Attachments: remove_per_thread_stats.patch
>
>
> ATS keeps a thread-local copy of the stat value and aggregates it periodically and on demand when stats are being collected. However the decrement function doesn't let a value go negative. So in a thread that has not incremented this stat previously, the decrement call "fails". This negative value check is logically flawed as it doesn't account for the per-thread distribution of the stats.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira