You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/08/10 01:20:12 UTC

Review Request 13454: Improved task validation error messages in master.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13454/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Ben Mahler, and Jie Yu.


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  src/common/type_utils.hpp 9320ced40d63a7883aced712113b67eaf3ca8925 
  src/master/master.cpp a2f8929987f95e796aba71063223aea7003bf3df 
  src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac 

Diff: https://reviews.apache.org/r/13454/diff/


Testing
-------

make


Thanks,

Vinod Kone

Re: Review Request 13454: Improved task validation error messages in master.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13454/
-----------------------------------------------------------

(Updated Aug. 13, 2013, 10:46 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

benm's. nnfr.


Repository: mesos-git


Description
-------

See summary.


Diffs (updated)
-----

  src/common/type_utils.hpp 9320ced40d63a7883aced712113b67eaf3ca8925 
  src/master/master.cpp b6d12a3a1ef0785800cadbdbd7141dd79190d3df 
  src/slave/slave.cpp dbc4473d37d6581f488ec39b7b7dcb5936935e6f 
  src/tests/resource_offers_tests.cpp a96e7757455ef9da21cf62e810f489415d3d2134 

Diff: https://reviews.apache.org/r/13454/diff/


Testing
-------

make check


Thanks,

Vinod Kone

Re: Review Request 13454: Improved task validation error messages in master.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13454/#review25020
-----------------------------------------------------------

Ship it!



src/master/master.cpp
<https://reviews.apache.org/r/13454/#comment49183>

    Why 56 dashes? How about 50?
    
    Can you add a newline where there are newlines in the string? So:
    
    ...
    "Existing ExecutorInfo:\n" + 
    stringify(executorInfo) + 
    ...



src/slave/slave.cpp
<https://reviews.apache.org/r/13454/#comment49184>

    Instead of 49 dashes can you use 50?


- Ben Mahler


On Aug. 12, 2013, 1:11 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13454/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2013, 1:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/common/type_utils.hpp 9320ced40d63a7883aced712113b67eaf3ca8925 
>   src/master/master.cpp a2f8929987f95e796aba71063223aea7003bf3df 
>   src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac 
>   src/tests/resource_offers_tests.cpp a96e7757455ef9da21cf62e810f489415d3d2134 
> 
> Diff: https://reviews.apache.org/r/13454/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 13454: Improved task validation error messages in master.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13454/
-----------------------------------------------------------

(Updated Aug. 12, 2013, 1:11 a.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

fixed tests.


Repository: mesos-git


Description
-------

See summary.


Diffs (updated)
-----

  src/common/type_utils.hpp 9320ced40d63a7883aced712113b67eaf3ca8925 
  src/master/master.cpp a2f8929987f95e796aba71063223aea7003bf3df 
  src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac 
  src/tests/resource_offers_tests.cpp a96e7757455ef9da21cf62e810f489415d3d2134 

Diff: https://reviews.apache.org/r/13454/diff/


Testing (updated)
-------

make check


Thanks,

Vinod Kone