You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bhaisaab <gi...@git.apache.org> on 2015/08/06 09:48:44 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8301: Enable configuring local...
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/661
CLOUDSTACK-8301: Enable configuring local storage use for system VMs …
…at zone level
Backported from #263 for 4.5 branch
More information on https://issues.apache.org/jira/browse/CLOUDSTACK-8301
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack 4.5-localstorage-zonewide-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/661.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #661
----
commit f2947f9dec90562b5d0d2208ce111dc6bd2ad393
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2015-08-06T06:43:01Z
CLOUDSTACK-8301: Enable configuring local storage use for system VMs at zone level
Backported from #263 for 4.5 branch
More information on https://issues.apache.org/jira/browse/CLOUDSTACK-8301
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8301: Enable configuring local...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/661#issuecomment-128342511
Changes LGTM. Make sure travis is green.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8301: Enable configuring local...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/661#issuecomment-128347115
@koushik-das thanks, looks like Travis failed due to some timeout issue and in other case due to dependency/jar issue. Will force push again to re-kick the travis job
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8301: Enable configuring local...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/661#issuecomment-128284375
@koushik-das I've backported your fix from master to 4.5 using the PR #263, please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8301: Enable configuring local...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/661#issuecomment-128280936
Created PR, still testing on KVM/4.5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8301: Enable configuring local...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/661#issuecomment-128288397
Tests fixed, hoping this will pass Travis now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8301: Enable configuring local...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/661#issuecomment-128685407
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8301: Enable configuring local...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/661#issuecomment-128693767
Travis is green and 2LGTM, merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8301: Enable configuring local...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/661
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8301: Enable configuring local...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/661#issuecomment-128300894
Did functional testing with two KVM hosts, across two Advance Zones with VLAN isolation:
The permutation was; Zone 1 with shared storage for user vms and local storage enabled for systemvms at the time of adding the zone, and Zone 2 with local storage for user vms and shared storage for systemvms (keeping the global setting use.systemvm.local.storage to false/default).
Infra looked like this, two hosts across two zones with both primary and secondary (zone wide) storages.
- Saw that systemvm and user vms disks were allocated on respective storage type as expected
- When Zone 1's setting use.systemvm.local.storage was set to false, new systemvm (VRs) came up on shared storage
- When global use.systemvm.local.storage was set to true, Zone2's VRs came up on local storage
- When use.systemvm.local.storage of Zone2 was set to true, VRs came up on local storage
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---