You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/09/29 09:19:23 UTC
[PR] Relocate Proxy YAML configuration and isolate public DistSQL [shardingsphere]
terrymanu opened a new pull request, #39999:
URL: https://github.com/apache/shardingsphere/pull/39999
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Relocate Proxy YAML configuration and isolate public DistSQL [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39999:
URL: https://github.com/apache/shardingsphere/pull/39999#issuecomment-5887310408
### Result
**Review Result: Mergeable**
The local refactor is complete. Proxy startup YAML classes now belong to `proxy/backend/core`; public DistSQL uses neutral YAML classes in `infra/distsql-handler`, and the JDBC paths remain available.
### Evidence
- The Proxy classes and data source conversion logic match the original implementation. The public classes preserve the YAML fields and defaults for database names, data sources, and rules.
- Focused tests for Proxy loading, YAML-to-DistSQL conversion, database and metadata import, and JDBC commands passed: 3, 61, 3, and 7 tests, respectively. All 27 changed Java files still present passed Spotless and Checkstyle; Apache RAT passed.
- Maven dependency and source checks confirm that `infra/distsql-handler` does not depend on Proxy. No module or SPI was added.
### Coverage
- Standalone local candidate based on `5cc2dff1000`; reviewed 30 task files across 4 modules. This is a local code review; CI was not reviewed.
- The former Proxy classes have new Java package names, as allowed by your instruction that compatibility is unnecessary. The YAML format remains unchanged.
- Downstream must adapt its own `YamlProxyDatabaseConfigurationSwapper` and the DTOs, swappers, and call sites involving `searchPath` and `passwordEncryptorName`. Downstream code was not verified here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Relocate Proxy YAML configuration and isolate public DistSQL [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39999:
URL: https://github.com/apache/shardingsphere/pull/39999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org