You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Swapan Shridhar <ss...@hortonworks.com> on 2016/04/28 03:41:36 UTC
Review Request 46760: AMBARI-16149. Support for LLAP alert in Ambari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46760/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit Mohanty.
Bugs: AMBARI-16149
https://issues.apache.org/jira/browse/AMBARI-16149
Repository: ambari
Description
-------
- Checks LLAP app status by running Hive Server2 " --service llapstatus --name <llapAppName>" command.
Diffs
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 9f0466c
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py PRE-CREATION
Diff: https://reviews.apache.org/r/46760/diff/
Testing
-------
Python UT passes.
File Attachments
----------------
App in COMPLETE state . Cluster Kerberized.
https://reviews.apache.org/media/uploaded/files/2016/04/28/7647a8e8-df5e-4d62-a6a5-0c13d7e47e96__Screen_Shot_2016-04-27_at_6.26.49_PM.png
App in RUNNING_ALL state . Cluster un-Kerberized.
https://reviews.apache.org/media/uploaded/files/2016/04/28/deaef102-4b0a-42a0-8262-31d357509048__Screen_Shot_2016-04-27_at_5.59.32_PM.png
App in LAUNCHING state . Cluster Kerberized.
https://reviews.apache.org/media/uploaded/files/2016/04/28/7a9c5482-f8e2-43e0-b9f9-08e5a62ed97b__Screen_Shot_2016-04-27_at_6.40.46_PM.png
Thanks,
Swapan Shridhar
Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in
Ambari
Posted by Swapan Shridhar <ss...@hortonworks.com>.
> On April 28, 2016, 2:50 p.m., Jonathan Hurley wrote:
> > I've never installed LLAP before - Is this data you're getting exposed via JMX as a metric? It it was, it would save you a lot of effort in getting things like liveInstances.
I dont think it's getting exposed via JMX. i'll still check with HIVE team.
> On April 28, 2016, 2:50 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py, lines 156-158
> > <https://reviews.apache.org/r/46760/diff/2/?file=1364429#file1364429line156>
> >
> > Why not use Execute here? Is it because you need the exit code? I don't see it being used.
Using this call because I need to use the o/p (a JSON).
> On April 28, 2016, 2:50 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py, lines 36-39
> > <https://reviews.apache.org/r/46760/diff/2/?file=1364429#file1364429line36>
> >
> > As these are user-facing strings, let's have them reviewed for grammar and clarity. They seem very sterile and don't flow very well.
Any inputs on this. I want state and/or instances to be shown for better clarity
- Swapan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46760/#review130918
-----------------------------------------------------------
On April 28, 2016, 9:52 a.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46760/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 9:52 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-16149
> https://issues.apache.org/jira/browse/AMBARI-16149
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Checks LLAP app status by running Hive Server2 " --service llapstatus --name <llapAppName>" command.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 9f0466c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py a556410
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 3d6c096
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml aad9c47
>
> Diff: https://reviews.apache.org/r/46760/diff/
>
>
> Testing
> -------
>
> Python UT passes.
>
>
> File Attachments
> ----------------
>
> App in COMPLETE state . Cluster Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/7647a8e8-df5e-4d62-a6a5-0c13d7e47e96__Screen_Shot_2016-04-27_at_6.26.49_PM.png
> App in RUNNING_ALL state . Cluster un-Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/deaef102-4b0a-42a0-8262-31d357509048__Screen_Shot_2016-04-27_at_5.59.32_PM.png
> App in LAUNCHING state . Cluster Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/7a9c5482-f8e2-43e0-b9f9-08e5a62ed97b__Screen_Shot_2016-04-27_at_6.40.46_PM.png
> Hive Metastore alert
> https://reviews.apache.org/media/uploaded/files/2016/04/28/0c495516-0e0b-4e46-a8c3-4ea03f32ab1d__Screen_Shot_2016-04-28_at_2.27.03_AM.png
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in
Ambari
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46760/#review130918
-----------------------------------------------------------
I've never installed LLAP before - Is this data you're getting exposed via JMX as a metric? It it was, it would save you a lot of effort in getting things like liveInstances.
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json (line 151)
<https://reviews.apache.org/r/46760/#comment194824>
Maybe preface with hive_ ?
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py (lines 178 - 179)
<https://reviews.apache.org/r/46760/#comment194825>
What are you formatting here? Seems like you could just append the string directly?
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py (lines 36 - 39)
<https://reviews.apache.org/r/46760/#comment194827>
As these are user-facing strings, let's have them reviewed for grammar and clarity. They seem very sterile and don't flow very well.
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py (lines 138 - 146)
<https://reviews.apache.org/r/46760/#comment194828>
This is probably OK, but some of the other alerts check the last time they ran kinit so that they don't do it every single time. If this is a single alert for a single LLAP instance, then it's probably fine.
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py (lines 156 - 158)
<https://reviews.apache.org/r/46760/#comment194829>
Why not use Execute here? Is it because you need the exit code? I don't see it being used.
- Jonathan Hurley
On April 28, 2016, 5:52 a.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46760/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 5:52 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-16149
> https://issues.apache.org/jira/browse/AMBARI-16149
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Checks LLAP app status by running Hive Server2 " --service llapstatus --name <llapAppName>" command.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 9f0466c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py a556410
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 3d6c096
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml aad9c47
>
> Diff: https://reviews.apache.org/r/46760/diff/
>
>
> Testing
> -------
>
> Python UT passes.
>
>
> File Attachments
> ----------------
>
> App in COMPLETE state . Cluster Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/7647a8e8-df5e-4d62-a6a5-0c13d7e47e96__Screen_Shot_2016-04-27_at_6.26.49_PM.png
> App in RUNNING_ALL state . Cluster un-Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/deaef102-4b0a-42a0-8262-31d357509048__Screen_Shot_2016-04-27_at_5.59.32_PM.png
> App in LAUNCHING state . Cluster Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/7a9c5482-f8e2-43e0-b9f9-08e5a62ed97b__Screen_Shot_2016-04-27_at_6.40.46_PM.png
> Hive Metastore alert
> https://reviews.apache.org/media/uploaded/files/2016/04/28/0c495516-0e0b-4e46-a8c3-4ea03f32ab1d__Screen_Shot_2016-04-28_at_2.27.03_AM.png
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in
Ambari
Posted by Swapan Shridhar <ss...@hortonworks.com>.
> On April 28, 2016, 8:15 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json, line 154
> > <https://reviews.apache.org/r/46760/diff/2/?file=1364427#file1364427line154>
> >
> > What's the average time to run?
> > Perhaps 4 or 5 is safer
Avg time to run is 8-10 secs on 3 node cluster.
- Swapan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46760/#review130985
-----------------------------------------------------------
On April 28, 2016, 9:52 a.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46760/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 9:52 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-16149
> https://issues.apache.org/jira/browse/AMBARI-16149
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Checks LLAP app status by running Hive Server2 " --service llapstatus --name <llapAppName>" command.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 9f0466c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py a556410
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 3d6c096
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml aad9c47
>
> Diff: https://reviews.apache.org/r/46760/diff/
>
>
> Testing
> -------
>
> Python UT passes.
>
>
> File Attachments
> ----------------
>
> App in COMPLETE state . Cluster Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/7647a8e8-df5e-4d62-a6a5-0c13d7e47e96__Screen_Shot_2016-04-27_at_6.26.49_PM.png
> App in RUNNING_ALL state . Cluster un-Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/deaef102-4b0a-42a0-8262-31d357509048__Screen_Shot_2016-04-27_at_5.59.32_PM.png
> App in LAUNCHING state . Cluster Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/7a9c5482-f8e2-43e0-b9f9-08e5a62ed97b__Screen_Shot_2016-04-27_at_6.40.46_PM.png
> Hive Metastore alert
> https://reviews.apache.org/media/uploaded/files/2016/04/28/0c495516-0e0b-4e46-a8c3-4ea03f32ab1d__Screen_Shot_2016-04-28_at_2.27.03_AM.png
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in
Ambari
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46760/#review130985
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json (line 154)
<https://reviews.apache.org/r/46760/#comment194900>
What's the average time to run?
Perhaps 4 or 5 is safer
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py (line 61)
<https://reviews.apache.org/r/46760/#comment194897>
STACK_ROOT_DEFAULT is not used, can remove it.
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py (line 154)
<https://reviews.apache.org/r/46760/#comment194898>
We shouldn't hardcode /usr/hdp
If stack root is missing, report an error
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py (line 159)
<https://reviews.apache.org/r/46760/#comment194899>
May want to make sure that output is not None before calling json.loads()
- Alejandro Fernandez
On April 28, 2016, 9:52 a.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46760/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 9:52 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-16149
> https://issues.apache.org/jira/browse/AMBARI-16149
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Checks LLAP app status by running Hive Server2 " --service llapstatus --name <llapAppName>" command.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 9f0466c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py a556410
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 3d6c096
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml aad9c47
>
> Diff: https://reviews.apache.org/r/46760/diff/
>
>
> Testing
> -------
>
> Python UT passes.
>
>
> File Attachments
> ----------------
>
> App in COMPLETE state . Cluster Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/7647a8e8-df5e-4d62-a6a5-0c13d7e47e96__Screen_Shot_2016-04-27_at_6.26.49_PM.png
> App in RUNNING_ALL state . Cluster un-Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/deaef102-4b0a-42a0-8262-31d357509048__Screen_Shot_2016-04-27_at_5.59.32_PM.png
> App in LAUNCHING state . Cluster Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/7a9c5482-f8e2-43e0-b9f9-08e5a62ed97b__Screen_Shot_2016-04-27_at_6.40.46_PM.png
> Hive Metastore alert
> https://reviews.apache.org/media/uploaded/files/2016/04/28/0c495516-0e0b-4e46-a8c3-4ea03f32ab1d__Screen_Shot_2016-04-28_at_2.27.03_AM.png
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in
Ambari
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46760/#review131142
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py (lines 178 - 179)
<https://reviews.apache.org/r/46760/#comment195077>
Can remove the format on the 2nd part of this.
- Alejandro Fernandez
On April 28, 2016, 9:52 a.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46760/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 9:52 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-16149
> https://issues.apache.org/jira/browse/AMBARI-16149
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Checks LLAP app status by running Hive Server2 " --service llapstatus --name <llapAppName>" command.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 9f0466c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py a556410
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 3d6c096
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml aad9c47
>
> Diff: https://reviews.apache.org/r/46760/diff/
>
>
> Testing
> -------
>
> Python UT passes.
>
>
> File Attachments
> ----------------
>
> App in COMPLETE state . Cluster Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/7647a8e8-df5e-4d62-a6a5-0c13d7e47e96__Screen_Shot_2016-04-27_at_6.26.49_PM.png
> App in RUNNING_ALL state . Cluster un-Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/deaef102-4b0a-42a0-8262-31d357509048__Screen_Shot_2016-04-27_at_5.59.32_PM.png
> App in LAUNCHING state . Cluster Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/7a9c5482-f8e2-43e0-b9f9-08e5a62ed97b__Screen_Shot_2016-04-27_at_6.40.46_PM.png
> Hive Metastore alert
> https://reviews.apache.org/media/uploaded/files/2016/04/28/0c495516-0e0b-4e46-a8c3-4ea03f32ab1d__Screen_Shot_2016-04-28_at_2.27.03_AM.png
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in
Ambari
Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46760/
-----------------------------------------------------------
(Updated April 28, 2016, 9:52 a.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit Mohanty.
Changes
-------
- Added fix for Hive Metastore Alert.
- Code cleanup.
- UT passes
Bugs: AMBARI-16149
https://issues.apache.org/jira/browse/AMBARI-16149
Repository: ambari
Description
-------
- Checks LLAP app status by running Hive Server2 " --service llapstatus --name <llapAppName>" command.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 9f0466c
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py a556410
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py PRE-CREATION
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 3d6c096
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml aad9c47
Diff: https://reviews.apache.org/r/46760/diff/
Testing
-------
Python UT passes.
File Attachments (updated)
----------------
App in COMPLETE state . Cluster Kerberized.
https://reviews.apache.org/media/uploaded/files/2016/04/28/7647a8e8-df5e-4d62-a6a5-0c13d7e47e96__Screen_Shot_2016-04-27_at_6.26.49_PM.png
App in RUNNING_ALL state . Cluster un-Kerberized.
https://reviews.apache.org/media/uploaded/files/2016/04/28/deaef102-4b0a-42a0-8262-31d357509048__Screen_Shot_2016-04-27_at_5.59.32_PM.png
App in LAUNCHING state . Cluster Kerberized.
https://reviews.apache.org/media/uploaded/files/2016/04/28/7a9c5482-f8e2-43e0-b9f9-08e5a62ed97b__Screen_Shot_2016-04-27_at_6.40.46_PM.png
Hive Metastore alert
https://reviews.apache.org/media/uploaded/files/2016/04/28/0c495516-0e0b-4e46-a8c3-4ea03f32ab1d__Screen_Shot_2016-04-28_at_2.27.03_AM.png
Thanks,
Swapan Shridhar
Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in
Ambari
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46760/#review130878
-----------------------------------------------------------
Ship it!
Fix the issues and ship.
- Sumit Mohanty
On April 28, 2016, 1:41 a.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46760/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 1:41 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-16149
> https://issues.apache.org/jira/browse/AMBARI-16149
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Checks LLAP app status by running Hive Server2 " --service llapstatus --name <llapAppName>" command.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 9f0466c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46760/diff/
>
>
> Testing
> -------
>
> Python UT passes.
>
>
> File Attachments
> ----------------
>
> App in COMPLETE state . Cluster Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/7647a8e8-df5e-4d62-a6a5-0c13d7e47e96__Screen_Shot_2016-04-27_at_6.26.49_PM.png
> App in RUNNING_ALL state . Cluster un-Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/deaef102-4b0a-42a0-8262-31d357509048__Screen_Shot_2016-04-27_at_5.59.32_PM.png
> App in LAUNCHING state . Cluster Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/7a9c5482-f8e2-43e0-b9f9-08e5a62ed97b__Screen_Shot_2016-04-27_at_6.40.46_PM.png
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in
Ambari
Posted by Swapan Shridhar <ss...@hortonworks.com>.
> On April 28, 2016, 2:50 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py, line 22
> > <https://reviews.apache.org/r/46760/diff/1/?file=1364283#file1364283line22>
> >
> > Lets remove all the commented lines.
Fixed.
> On April 28, 2016, 2:50 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py, line 38
> > <https://reviews.apache.org/r/46760/diff/1/?file=1364283#file1364283line38>
> >
> > Wasn't there a fix for Hive Metastore Alert as well?
Fixed. Had a separate bug on it. Adding to this now.
> On April 28, 2016, 2:50 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py, line 88
> > <https://reviews.apache.org/r/46760/diff/1/?file=1364283#file1364283line88>
> >
> > lets delete this.
Done.
> On April 28, 2016, 2:50 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py, line 122
> > <https://reviews.apache.org/r/46760/diff/1/?file=1364283#file1364283line122>
> >
> > There is no config property here - I assume. I was wondering if we can read from a property rather than making it a constant.
Added a config prop.
> On April 28, 2016, 2:50 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py, line 220
> > <https://reviews.apache.org/r/46760/diff/1/?file=1364283#file1364283line220>
> >
> > Lets remove this.
Done.
- Swapan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46760/#review130876
-----------------------------------------------------------
On April 28, 2016, 1:41 a.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46760/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 1:41 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-16149
> https://issues.apache.org/jira/browse/AMBARI-16149
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Checks LLAP app status by running Hive Server2 " --service llapstatus --name <llapAppName>" command.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 9f0466c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46760/diff/
>
>
> Testing
> -------
>
> Python UT passes.
>
>
> File Attachments
> ----------------
>
> App in COMPLETE state . Cluster Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/7647a8e8-df5e-4d62-a6a5-0c13d7e47e96__Screen_Shot_2016-04-27_at_6.26.49_PM.png
> App in RUNNING_ALL state . Cluster un-Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/deaef102-4b0a-42a0-8262-31d357509048__Screen_Shot_2016-04-27_at_5.59.32_PM.png
> App in LAUNCHING state . Cluster Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/7a9c5482-f8e2-43e0-b9f9-08e5a62ed97b__Screen_Shot_2016-04-27_at_6.40.46_PM.png
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in
Ambari
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46760/#review130876
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py (line 22)
<https://reviews.apache.org/r/46760/#comment194793>
Lets remove all the commented lines.
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py (line 38)
<https://reviews.apache.org/r/46760/#comment194794>
Wasn't there a fix for Hive Metastore Alert as well?
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py (line 88)
<https://reviews.apache.org/r/46760/#comment194795>
lets delete this.
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py (line 122)
<https://reviews.apache.org/r/46760/#comment194796>
There is no config property here - I assume. I was wondering if we can read from a property rather than making it a constant.
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py (line 220)
<https://reviews.apache.org/r/46760/#comment194797>
Lets remove this.
- Sumit Mohanty
On April 28, 2016, 1:41 a.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46760/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 1:41 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-16149
> https://issues.apache.org/jira/browse/AMBARI-16149
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Checks LLAP app status by running Hive Server2 " --service llapstatus --name <llapAppName>" command.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 9f0466c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46760/diff/
>
>
> Testing
> -------
>
> Python UT passes.
>
>
> File Attachments
> ----------------
>
> App in COMPLETE state . Cluster Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/7647a8e8-df5e-4d62-a6a5-0c13d7e47e96__Screen_Shot_2016-04-27_at_6.26.49_PM.png
> App in RUNNING_ALL state . Cluster un-Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/deaef102-4b0a-42a0-8262-31d357509048__Screen_Shot_2016-04-27_at_5.59.32_PM.png
> App in LAUNCHING state . Cluster Kerberized.
> https://reviews.apache.org/media/uploaded/files/2016/04/28/7a9c5482-f8e2-43e0-b9f9-08e5a62ed97b__Screen_Shot_2016-04-27_at_6.40.46_PM.png
>
>
> Thanks,
>
> Swapan Shridhar
>
>