[I] [Bug] Lite client offline cleanup logs full gRPC Settings on failure [rocketmq]

["Aias00 (via GitHub)" <gi...@apache.org>]

Aias00 opened a new issue, #10710:
URL: https://github.com/apache/rocketmq/issues/10710

   ### Before Creating the Bug Report
   
   - [x] I found a bug, not just asking a question, which should be created in GitHub Issues.
   - [x] I have searched the existing issues and believe this is not a duplicate.
   - [x] I have confirmed that this bug belongs to the current repository.
   
   ### Describe the Bug
   
   `GrpcClientSettingsManager#offlineClientLiteSubscription` logs the full gRPC `Settings` object when cleanup fails:
   
   ```java
   log.error("offlineClientLiteSubscription error, clientId:{}, settings:{}", clientId, settings, e);
   ```
   
   `Settings` can contain client runtime metadata, subscription details, metric endpoint information, and future fields added by gRPC clients. Logging the whole protobuf object is unnecessary for diagnostics and can leak more client metadata than intended.
   
   This is similar in spirit to recent telemetry log sanitization work, but this path is separate from `TelemetryCommand` write/exception logging.
   
   ### Expected Behavior
   
   Failure logs should keep useful diagnostic fields while avoiding full protobuf serialization. For example, log only:
   
   - client id
   - client type
   - consumer group
   - first topic / topic count
   - subscription count
   
   The cleanup behavior should stay unchanged.
   
   ### Scope
   
   RocketMQ Studio Track 2 / Proxy gRPC client diagnostics and safe operational logging.
   
   ### Proposed Fix
   
   Replace the full `settings:{}` log argument with a compact sanitized summary helper, and add a regression test that verifies the summary does not include full subscription/filter details while preserving diagnostic fields.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Bug] Lite client offline cleanup logs full gRPC Settings on failure [rocketmq]

["Aias00 (via GitHub) via commits" <co...@rocketmq.apache.org>]

Aias00 closed issue #10710: [Bug] Lite client offline cleanup logs full gRPC Settings on failure
URL: https://github.com/apache/rocketmq/issues/10710


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Bug] Lite client offline cleanup logs full gRPC Settings on failure [rocketmq]

["RockteMQ-AI (via GitHub)" <gi...@apache.org>]

RockteMQ-AI commented on issue #10710:
URL: https://github.com/apache/rocketmq/issues/10710#issuecomment-5140735676

   **Issue Evaluation**
   
   Category: `type/bug` | Status: **Confirmed**
   
   The reported issue has been verified against the current codebase.
   
   **Root Cause:** In `GrpcClientSettingsManager#offlineClientLiteSubscription` (line 256), the error log serializes the full protobuf `Settings` object:
   ```java
   log.error("offlineClientLiteSubscription error, clientId:{}, settings:{}", clientId, settings, e);
   ```
   `Settings` can contain subscription details, metric endpoint info, and other client runtime metadata. This is unnecessary for diagnostics and may leak more client metadata than intended.
   
   **Impact:** Proxy gRPC client diagnostics — operational logs may contain excessive client metadata.
   **Severity:** Low (no functional impact, information hygiene concern)
   
   An automated fix proposal can be generated. Reply `/approve` to proceed with PR generation.
   
   ---
   *Automated evaluation by RockteMQ-AI*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org