You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2021/10/19 15:42:57 UTC

[GitHub] [avro] zcsizmadia opened a new pull request #1376: AVRO-3238: Unify TargetFrameworks for C# projects

zcsizmadia opened a new pull request #1376:
URL: https://github.com/apache/avro/pull/1376


   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/3238)
     - https://issues.apache.org/jira/browse/AVRO-3238
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] zcsizmadia edited a comment on pull request #1376: AVRO-3238: Unify TargetFrameworks for C# projects

Posted by GitBox <gi...@apache.org>.
zcsizmadia edited a comment on pull request #1376:
URL: https://github.com/apache/avro/pull/1376#issuecomment-946856731


   @RyanSkraba Thi is th PR I mentioned in #1375 
   
   Once #1375 is merged, this PR has to be merged with master and update the C# README.MD file to reflect the changes to the TargetFrameworks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g commented on pull request #1376: AVRO-3238: Unify TargetFrameworks for C# projects

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1376:
URL: https://github.com/apache/avro/pull/1376#issuecomment-1008807048


   @zcsizmadia Coould you please resolve the conflicts ? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g merged pull request #1376: AVRO-3238: Unify TargetFrameworks for C# projects

Posted by GitBox <gi...@apache.org>.
martin-g merged pull request #1376:
URL: https://github.com/apache/avro/pull/1376


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g edited a comment on pull request #1376: AVRO-3238: Unify TargetFrameworks for C# projects

Posted by GitBox <gi...@apache.org>.
martin-g edited a comment on pull request #1376:
URL: https://github.com/apache/avro/pull/1376#issuecomment-1008807048


   @zcsizmadia Could you please resolve the conflicts ? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g commented on pull request #1376: AVRO-3238: Unify TargetFrameworks for C# projects

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1376:
URL: https://github.com/apache/avro/pull/1376#issuecomment-1008894737


   Thank you, @zcsizmadia !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] zcsizmadia commented on pull request #1376: AVRO-3238: Unify TargetFrameworks for C# projects

Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1376:
URL: https://github.com/apache/avro/pull/1376#issuecomment-946856731


   @RyanSkraba Thi is th PR I mentioned in #1375 
   
   Once #1375 is merged, this PR has to merged with master and update the C# README.MD file to reflect the changes to the TargetFrameworks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org