You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/12 09:52:10 UTC
[GitHub] [flink-table-store] JingsongLi opened a new pull request, #432: [FLINK-30373] Flink-table-runtime free for flink-table-store-codegen
JingsongLi opened a new pull request, #432:
URL: https://github.com/apache/flink-table-store/pull/432
- Copy `GeneratedClass`, It is now an implementation class, representing different codegen classes through generics.
- Copy `CompileUtils`.
- Copy `BinaryIndexedSortable` and `BinaryExternalMerger` for new `RecordComparator`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] zjureel commented on a diff in pull request #432: [FLINK-30373] Flink-table-runtime free for flink-table-store-codegen
Posted by GitBox <gi...@apache.org>.
zjureel commented on code in PR #432:
URL: https://github.com/apache/flink-table-store/pull/432#discussion_r1046573828
##########
flink-table-store-common/src/main/java/org/apache/flink/table/store/codegen/Projection.java:
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.store.codegen;
+
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.data.binary.BinaryRowData;
+
+/**
+ * Interface for code generated projection, which will map a RowData to another BinaryRowData.
+ * Copied from Flink.
+ */
+public interface Projection {
+
+ BinaryRowData apply(RowData row);
Review Comment:
I found the class in Flink is `Projection<IN extends RowData, OUT extends RowData>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] zjureel commented on a diff in pull request #432: [FLINK-30373] Flink-table-runtime free for flink-table-store-codegen
Posted by GitBox <gi...@apache.org>.
zjureel commented on code in PR #432:
URL: https://github.com/apache/flink-table-store/pull/432#discussion_r1046572553
##########
flink-table-store-common/src/main/java/org/apache/flink/table/store/codegen/Projection.java:
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.store.codegen;
+
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.data.binary.BinaryRowData;
+
+/**
+ * Interface for code generated projection, which will map a RowData to another BinaryRowData.
+ * Copied from Flink.
+ */
+public interface Projection {
+
+ BinaryRowData apply(RowData row);
Review Comment:
Should `BinaryRowData` be used here? How about `RowData`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] zjureel commented on pull request #432: [FLINK-30373] Flink-table-runtime free for flink-table-store-codegen
Posted by GitBox <gi...@apache.org>.
zjureel commented on PR #432:
URL: https://github.com/apache/flink-table-store/pull/432#issuecomment-1347626712
Hi @JingsongLi Left one minor comment
In addition, I found that `flink-table-store-codegen` module still depends on `flink-table-runtime` in `pom.xml`, is it OK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on pull request #432: [FLINK-30373] Flink-table-runtime free for flink-table-store-codegen
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on PR #432:
URL: https://github.com/apache/flink-table-store/pull/432#issuecomment-1347634926
> Hi @JingsongLi Left one minor comment
>
> In addition, I found that `flink-table-store-codegen` module still depends on `flink-table-runtime` in `pom.xml`, is it OK?
Good question, yes, still depends on runtime, the main problem is that they have not been completely stripped. If dependencies are removed, the packages may be affected.
My idea is that after most of the work is done, we can look at the separation of this dependency to avoid affecting the release of 0.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #432: [FLINK-30373] Flink-table-runtime free for flink-table-store-codegen
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on code in PR #432:
URL: https://github.com/apache/flink-table-store/pull/432#discussion_r1046583371
##########
flink-table-store-common/src/main/java/org/apache/flink/table/store/codegen/Projection.java:
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.store.codegen;
+
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.data.binary.BinaryRowData;
+
+/**
+ * Interface for code generated projection, which will map a RowData to another BinaryRowData.
+ * Copied from Flink.
+ */
+public interface Projection {
+
+ BinaryRowData apply(RowData row);
Review Comment:
The project from the codegen must return `BinaryRowData`. We also need to use `BinaryRowData`. For example, in `BucketComputer`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] zjureel commented on pull request #432: [FLINK-30373] Flink-table-runtime free for flink-table-store-codegen
Posted by GitBox <gi...@apache.org>.
zjureel commented on PR #432:
URL: https://github.com/apache/flink-table-store/pull/432#issuecomment-1347661426
> > Hi @JingsongLi Left one minor comment
> > In addition, I found that `flink-table-store-codegen` module still depends on `flink-table-runtime` in `pom.xml`, is it OK?
>
> Good question, yes, still depends on runtime, the main problem is that they have not been completely stripped. If dependencies are removed, the packages may be affected. My idea is that after most of the work is done, we can look at the separation of this dependency to avoid affecting the release of 0.3.
LGTM +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi merged pull request #432: [FLINK-30373] Flink-table-runtime free for flink-table-store-codegen
Posted by GitBox <gi...@apache.org>.
JingsongLi merged PR #432:
URL: https://github.com/apache/flink-table-store/pull/432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org