You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/08/17 01:41:12 UTC
Review Request 37511: Fixed master to reject non-subscribe calls made
before subscription.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37511/
-----------------------------------------------------------
Review request for mesos and Anand Mazumdar.
Repository: mesos
Description
-------
As the design doc says the master should reject non-subscribe calls if framework hasn't registered yet.
Diffs
-----
src/master/http.cpp a73ee17bcef72791b06240a4673f466de582c41b
Diff: https://reviews.apache.org/r/37511/diff/
Testing
-------
make check
No new tests yet because it's not clear how to simulate scheduler disconnection on the master.
Thanks,
Vinod Kone
Re: Review Request 37511: Fixed master to reject non-subscribe calls
made before subscription.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37511/#review95559
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 八月 16, 2015, 11:41 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37511/
> -----------------------------------------------------------
>
> (Updated 八月 16, 2015, 11:41 p.m.)
>
>
> Review request for mesos and Anand Mazumdar.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As the design doc says the master should reject non-subscribe calls if framework hasn't registered yet.
>
>
> Diffs
> -----
>
> src/master/http.cpp a73ee17bcef72791b06240a4673f466de582c41b
>
> Diff: https://reviews.apache.org/r/37511/diff/
>
>
> Testing
> -------
>
> make check
>
> No new tests yet because it's not clear how to simulate scheduler disconnection on the master.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 37511: Fixed master to reject non-subscribe calls
made before subscription.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37511/#review95579
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37511]
All tests passed.
- Mesos ReviewBot
On Aug. 16, 2015, 11:41 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37511/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2015, 11:41 p.m.)
>
>
> Review request for mesos and Anand Mazumdar.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As the design doc says the master should reject non-subscribe calls if framework hasn't registered yet.
>
>
> Diffs
> -----
>
> src/master/http.cpp a73ee17bcef72791b06240a4673f466de582c41b
>
> Diff: https://reviews.apache.org/r/37511/diff/
>
>
> Testing
> -------
>
> make check
>
> No new tests yet because it's not clear how to simulate scheduler disconnection on the master.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 37511: Fixed master to reject non-subscribe calls
made before subscription.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37511/#review95590
-----------------------------------------------------------
Ship it!
Ship It!
- Anand Mazumdar
On Aug. 16, 2015, 11:41 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37511/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2015, 11:41 p.m.)
>
>
> Review request for mesos and Anand Mazumdar.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As the design doc says the master should reject non-subscribe calls if framework hasn't registered yet.
>
>
> Diffs
> -----
>
> src/master/http.cpp a73ee17bcef72791b06240a4673f466de582c41b
>
> Diff: https://reviews.apache.org/r/37511/diff/
>
>
> Testing
> -------
>
> make check
>
> No new tests yet because it's not clear how to simulate scheduler disconnection on the master.
>
>
> Thanks,
>
> Vinod Kone
>
>