You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "justaparth (via GitHub)" <gi...@apache.org> on 2023/04/27 23:17:39 UTC

[GitHub] [spark] justaparth commented on pull request #40686: [SPARK-43051][CONNECTOR] Add option to materialize zero values for fields without presence information

justaparth commented on PR #40686:
URL: https://github.com/apache/spark/pull/40686#issuecomment-1526729416

   @rangadi thanks for the comments! i've updated the pr quite a bit, namely i've split it up into two commits:
   - commit 1: add tests that show the current state
   - commit 2: add flag + modify tests to show what changed
   
   and i addressed many of your comments as well along the way 🙏 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org