You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Tristan Stevens via Review Board <no...@reviews.apache.org> on 2019/02/13 18:46:56 UTC
Review Request 69975: SENTRY-2495: Support Conjunctive Matching in
Solr QueryDocAuthorizationComponent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69975/
-----------------------------------------------------------
Review request for sentry.
Repository: sentry
Description
-------
Adds a conjunctive match capabiltiy to the existing QueryDocAuthorizationComponent (which applies document level security against Sentry roles)
Diffs
-----
sentry-solr/solr-sentry-handlers/pom.xml 621d8325
sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/component/QueryDocAuthorizationComponent.java 9da3d6e1
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/AbstractSolrSentryTestCase.java 3d4d555f
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/DocLevelGenerator.java 40cc153e
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/SolrSentryServiceTestBase.java e1f789cb
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestDocLevelOperations.java 7834f339
sentry-tests/sentry-tests-solr/src/test/resources/log4j.properties d9418167
Diff: https://reviews.apache.org/r/69975/diff/1/
Testing
-------
Unit tests added for SubsetQueryPlugin
End-to-end tests added under sentry-tests/senty-tests-solr for full SolrCloud+Sentry Service using the new QueryDocAuthorizationComponent in conjunctive match mode
Thanks,
Tristan Stevens
Re: Review Request 69975: SENTRY-2495: Support Conjunctive Matching
in Solr QueryDocAuthorizationComponent
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69975/#review212871
-----------------------------------------------------------
Ship it!
Code change looks good.
- kalyan kumar kalvagadda
On Feb. 13, 2019, 6:46 p.m., Tristan Stevens wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69975/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2019, 6:46 p.m.)
>
>
> Review request for sentry.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Adds a conjunctive match capabiltiy to the existing QueryDocAuthorizationComponent (which applies document level security against Sentry roles)
>
>
> Diffs
> -----
>
> sentry-solr/solr-sentry-handlers/pom.xml 621d8325
> sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/component/QueryDocAuthorizationComponent.java 9da3d6e1
> sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/AbstractSolrSentryTestCase.java 3d4d555f
> sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/DocLevelGenerator.java 40cc153e
> sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/SolrSentryServiceTestBase.java e1f789cb
> sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestDocLevelOperations.java 7834f339
> sentry-tests/sentry-tests-solr/src/test/resources/log4j.properties d9418167
>
>
> Diff: https://reviews.apache.org/r/69975/diff/1/
>
>
> Testing
> -------
>
> Unit tests added for SubsetQueryPlugin
> End-to-end tests added under sentry-tests/senty-tests-solr for full SolrCloud+Sentry Service using the new QueryDocAuthorizationComponent in conjunctive match mode
>
>
> Thanks,
>
> Tristan Stevens
>
>
Re: Review Request 69975: SENTRY-2495: Support Conjunctive Matching
in Solr QueryDocAuthorizationComponent
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69975/#review212872
-----------------------------------------------------------
Ship it!
Ship It!
- kalyan kumar kalvagadda
On Feb. 15, 2019, 4:54 p.m., Tristan Stevens wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69975/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2019, 4:54 p.m.)
>
>
> Review request for sentry.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Adds a conjunctive match capabiltiy to the existing QueryDocAuthorizationComponent (which applies document level security against Sentry roles)
>
>
> Diffs
> -----
>
> sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/component/DocAuthorizationComponent.java PRE-CREATION
> sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/component/QueryDocAuthorizationComponent.java 9da3d6e1
> sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/component/SubsetQueryPlugin.java PRE-CREATION
> sentry-solr/solr-sentry-handlers/src/test/java/org/apache/solr/handler/component/SubsetQueryTest.java PRE-CREATION
> sentry-solr/solr-sentry-handlers/src/test/resources/solr/collection1/schema-docValuesSubsetMatch.xml PRE-CREATION
> sentry-solr/solr-sentry-handlers/src/test/resources/solr/collection1/solrconfig-subsetmatchcomponent.xml PRE-CREATION
> sentry-solr/solr-sentry-handlers/src/test/resources/solr/collection1/solrconfig-subsetquery.xml PRE-CREATION
> sentry-solr/solr-sentry-handlers/src/test/resources/solr/collection1/solrconfig.snippet.randomindexconfig.xml PRE-CREATION
> sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/AbstractSolrSentryTestCase.java 3d4d555f
> sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/DocLevelGenerator.java 40cc153e
> sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/SolrSentryServiceTestBase.java e1f789cb
> sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestDocLevelOperations.java 7834f339
> sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestSubsetQueryOperations.java PRE-CREATION
> sentry-tests/sentry-tests-solr/src/test/resources/log4j.properties d9418167
> sentry-tests/sentry-tests-solr/src/test/resources/solr/configsets/cloud-minimal_subset_match/conf/schema.xml PRE-CREATION
> sentry-tests/sentry-tests-solr/src/test/resources/solr/configsets/cloud-minimal_subset_match/conf/solrconfig.xml PRE-CREATION
> sentry-tests/sentry-tests-solr/src/test/resources/solr/configsets/cloud-minimal_subset_match_missing_false/conf/schema.xml PRE-CREATION
> sentry-tests/sentry-tests-solr/src/test/resources/solr/configsets/cloud-minimal_subset_match_missing_false/conf/solrconfig.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/69975/diff/2/
>
>
> Testing
> -------
>
> Unit tests added for SubsetQueryPlugin
> End-to-end tests added under sentry-tests/senty-tests-solr for full SolrCloud+Sentry Service using the new QueryDocAuthorizationComponent in conjunctive match mode
>
>
> Thanks,
>
> Tristan Stevens
>
>
Re: Review Request 69975: SENTRY-2495: Support Conjunctive Matching
in Solr QueryDocAuthorizationComponent
Posted by Tristan Stevens via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69975/
-----------------------------------------------------------
(Updated Feb. 15, 2019, 4:54 p.m.)
Review request for sentry.
Changes
-------
Updated patch with missing file(s)
Repository: sentry
Description
-------
Adds a conjunctive match capabiltiy to the existing QueryDocAuthorizationComponent (which applies document level security against Sentry roles)
Diffs (updated)
-----
sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/component/DocAuthorizationComponent.java PRE-CREATION
sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/component/QueryDocAuthorizationComponent.java 9da3d6e1
sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/component/SubsetQueryPlugin.java PRE-CREATION
sentry-solr/solr-sentry-handlers/src/test/java/org/apache/solr/handler/component/SubsetQueryTest.java PRE-CREATION
sentry-solr/solr-sentry-handlers/src/test/resources/solr/collection1/schema-docValuesSubsetMatch.xml PRE-CREATION
sentry-solr/solr-sentry-handlers/src/test/resources/solr/collection1/solrconfig-subsetmatchcomponent.xml PRE-CREATION
sentry-solr/solr-sentry-handlers/src/test/resources/solr/collection1/solrconfig-subsetquery.xml PRE-CREATION
sentry-solr/solr-sentry-handlers/src/test/resources/solr/collection1/solrconfig.snippet.randomindexconfig.xml PRE-CREATION
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/AbstractSolrSentryTestCase.java 3d4d555f
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/DocLevelGenerator.java 40cc153e
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/SolrSentryServiceTestBase.java e1f789cb
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestDocLevelOperations.java 7834f339
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestSubsetQueryOperations.java PRE-CREATION
sentry-tests/sentry-tests-solr/src/test/resources/log4j.properties d9418167
sentry-tests/sentry-tests-solr/src/test/resources/solr/configsets/cloud-minimal_subset_match/conf/schema.xml PRE-CREATION
sentry-tests/sentry-tests-solr/src/test/resources/solr/configsets/cloud-minimal_subset_match/conf/solrconfig.xml PRE-CREATION
sentry-tests/sentry-tests-solr/src/test/resources/solr/configsets/cloud-minimal_subset_match_missing_false/conf/schema.xml PRE-CREATION
sentry-tests/sentry-tests-solr/src/test/resources/solr/configsets/cloud-minimal_subset_match_missing_false/conf/solrconfig.xml PRE-CREATION
Diff: https://reviews.apache.org/r/69975/diff/2/
Changes: https://reviews.apache.org/r/69975/diff/1-2/
Testing
-------
Unit tests added for SubsetQueryPlugin
End-to-end tests added under sentry-tests/senty-tests-solr for full SolrCloud+Sentry Service using the new QueryDocAuthorizationComponent in conjunctive match mode
Thanks,
Tristan Stevens