You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Pierre Cheynier <me...@pierre-cheynier.net> on 2016/03/21 14:20:37 UTC

Review Request 45104: Use chmod+x to make termos_runner.pex executable

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45104/
-----------------------------------------------------------

Review request for Aurora.


Repository: aurora


Description
-------

When using `--executor_environment_variables` without explicitely
passing LD_LIBRARY_PATH, `sys.executable` returns an empty string
resulting in a '[Errno 13] Permission denied' error for every launched
task.

Moreover, it seems that this feature is coming in 0.30: "Executors no
longer inherit environment variables from the agent".

This patch partially revert back 07ce21d where chmod_x method was
removed in favor of using sys.executable.


Diffs
-----

  src/main/python/apache/aurora/executor/thermos_task_runner.py 3896e3841562600379705dbf78a6f62728246348 

Diff: https://reviews.apache.org/r/45104/diff/


Testing
-------

Make Aurora run on CentOS7


Thanks,

Pierre Cheynier