You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "guilbill (via GitHub)" <gi...@apache.org> on 2025/09/29 08:21:03 UTC

[PR] docs: update powered-by.md [apisix]

guilbill opened a new pull request, #12643:
URL: https://github.com/apache/apisix/pull/12643

   ### Description
   
   <!-- Please include a summary of the change and which issue is fixed. -->
   <!-- Please also include relevant motivation and context. -->
   Add react-admin in poweredBy.md
   
   #### Which issue(s) this PR fixes:
   <!--
   *Automatically closes linked issue when PR is merged.
   Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
   -->
   Fixes #
   
   ### Checklist
   
   - [ ] I have explained the need for this PR and the problem it solves
   - [ ] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] docs: update powered-by.md [apisix]

Posted by "guilbill (via GitHub)" <gi...@apache.org>.
guilbill commented on code in PR #12643:
URL: https://github.com/apache/apisix/pull/12643#discussion_r2390211294


##########
powered-by.md:
##########
@@ -65,6 +65,7 @@ Users are encouraged to add themselves to this page, [issue](https://github.com/
 1. <a href="https://www.jpl.nasa.gov" rel="nofollow">NASA JPL 美国国家航空航天局 喷气推进实验室</a>
 1. <a href="https://www.purcotton.com/" rel="nofollow">Purcotton 深圳全棉时代科技有限公司</a>
 1. <a href="https://www.360.cn/" rel="nofollow">360 奇虎</a>
+1. <a href="https://marmelab.com/react-admin/AuthProviderList.html" rel="nofollow">React-admin</a>

Review Comment:
   I wasn't sure what to link... React-admin is a frontend framework for building B2B applications with React. It works with data providers to plug the admin to an api, and auth providers to plug the admin to whatever can handle authentication. One of the Auth-providers is @arte/ra-apisix-oidc that allows you to use apisix authentication.
   
   So as I found that linking to React-admin homepage would be confusing, I choosed to link to the documentation refering to the authProvider list, where you can see the Apisix one.
   
   Is it clearer and does it seems relevant ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] docs: update powered-by.md [apisix]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12643:
URL: https://github.com/apache/apisix/pull/12643#issuecomment-3591526640

   This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] docs: update powered-by.md [apisix]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12643:
URL: https://github.com/apache/apisix/pull/12643#issuecomment-3694623585

   This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] docs: update powered-by.md [apisix]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #12643: docs: update powered-by.md
URL: https://github.com/apache/apisix/pull/12643


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] docs: update powered-by.md [apisix]

Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on code in PR #12643:
URL: https://github.com/apache/apisix/pull/12643#discussion_r2387641503


##########
powered-by.md:
##########
@@ -65,6 +65,7 @@ Users are encouraged to add themselves to this page, [issue](https://github.com/
 1. <a href="https://www.jpl.nasa.gov" rel="nofollow">NASA JPL 美国国家航空航天局 喷气推进实验室</a>
 1. <a href="https://www.purcotton.com/" rel="nofollow">Purcotton 深圳全棉时代科技有限公司</a>
 1. <a href="https://www.360.cn/" rel="nofollow">360 奇虎</a>
+1. <a href="https://marmelab.com/react-admin/AuthProviderList.html" rel="nofollow">React-admin</a>

Review Comment:
   I don't understand what this page is supposed to mean. Why isn't it the homepage?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] docs: update powered-by.md [apisix]

Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on code in PR #12643:
URL: https://github.com/apache/apisix/pull/12643#discussion_r2390366500


##########
powered-by.md:
##########
@@ -65,6 +65,7 @@ Users are encouraged to add themselves to this page, [issue](https://github.com/
 1. <a href="https://www.jpl.nasa.gov" rel="nofollow">NASA JPL 美国国家航空航天局 喷气推进实验室</a>
 1. <a href="https://www.purcotton.com/" rel="nofollow">Purcotton 深圳全棉时代科技有限公司</a>
 1. <a href="https://www.360.cn/" rel="nofollow">360 奇虎</a>
+1. <a href="https://marmelab.com/react-admin/AuthProviderList.html" rel="nofollow">React-admin</a>

Review Comment:
   I don't see the relevance here. I'll wait for other maintainers' opinions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org