[GitHub] [superset] michael-s-molina commented on a change in pull request #15798: feat(explore): default aggregate for string/numeric columns when creating metric

[GitBox <gi...@apache.org>]

michael-s-molina commented on a change in pull request #15798:
URL: https://github.com/apache/superset/pull/15798#discussion_r673143421



##########
File path: superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricPopoverTrigger.tsx
##########
@@ -76,6 +76,26 @@ class AdhocMetricPopoverTrigger extends React.PureComponent<
     };
   }
 
+  componentDidUpdate(
+    prevProps: Readonly<AdhocMetricPopoverTriggerProps>,
+    prevState: Readonly<AdhocMetricPopoverTriggerState>,
+    snapshot?: any,
+  ) {

Review comment:
       ```suggestion
     componentDidUpdate(prevProps: Readonly<AdhocMetricPopoverTriggerProps>) {
   ```
   
   Is not the case for [getDerivedStateFromProps](https://reactjs.org/docs/react-component.html#static-getderivedstatefromprops)?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org