You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/08 11:06:05 UTC
[GitHub] [airflow] potiuk opened a new pull request #12178: Adds extra check while the selective checks are run
potiuk opened a new pull request #12178:
URL: https://github.com/apache/airflow/pull/12178
The selective checks are run in "workflow_run" because
they need to be able to set label and make comments, however
status of those checks are not displayed in GitHub and in
cases of small PRs the "merge" button might be green before
the status complete.
This PR adds additional check that is always completed after
the "worfklow_run" finishes it's job. This will prevent
accidental merges before the check completes.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12178: Adds extra check while the selective checks are run
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12178:
URL: https://github.com/apache/airflow/pull/12178#issuecomment-723562067
cc: @TobKed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12178: Adds extra check while the selective checks are run
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12178:
URL: https://github.com/apache/airflow/pull/12178#issuecomment-723567849
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #12178: Adds extra check while the selective checks are run
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #12178:
URL: https://github.com/apache/airflow/pull/12178
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12178: Adds extra check while the selective checks are run
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12178:
URL: https://github.com/apache/airflow/pull/12178#issuecomment-723562002
This check is useful to know that checking the "status" of the selective check is still in progress (and it provides a link you can clikc through to see the running "workflow_run" check - similarly to the running "build image" workflow runs).
Also it will decrease the likeliihood of accidentally merging PRs that require "full tests" - we get the "in-progress" check as soon as the workflow_run starts and checking the status might take some time (20 seconds sometime). During this time, the "squash & merge " button will not be green.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org