You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Guillaume Nodet (JIRA)" <ji...@apache.org> on 2009/02/05 09:13:59 UTC

[jira] Created: (GSHELL-157) Dynamically adding / removing commands does not work well

Dynamically adding / removing commands does not work well
---------------------------------------------------------

                 Key: GSHELL-157
                 URL: https://issues.apache.org/jira/browse/GSHELL-157
             Project: GShell
          Issue Type: Bug
      Security Level: public (Regular issues)
            Reporter: Guillaume Nodet
            Assignee: Guillaume Nodet
             Fix For: 1.0-alpha-2


When resolving commands, the command resolver uses a virtual file system.  Unfortunately, the data for virtual file systems is always cached, which means that removing a command will still make it available for resolution.  
The cache problem is caused by the DelegateFileObject which does not refresh the underlying file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GSHELL-157) Dynamically adding / removing commands does not work well

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GSHELL-157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671563#action_12671563 ] 

Jason Dillon commented on GSHELL-157:
-------------------------------------

Ya, a side effect of leaning on VFS to handle the storage, I notice there is a problem with setting/unsetting/setting aliases too.

> Dynamically adding / removing commands does not work well
> ---------------------------------------------------------
>
>                 Key: GSHELL-157
>                 URL: https://issues.apache.org/jira/browse/GSHELL-157
>             Project: GShell
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>            Reporter: Guillaume Nodet
>            Assignee: Guillaume Nodet
>             Fix For: 1.0-alpha-2
>
>
> When resolving commands, the command resolver uses a virtual file system.  Unfortunately, the data for virtual file systems is always cached, which means that removing a command will still make it available for resolution.  
> The cache problem is caused by the DelegateFileObject which does not refresh the underlying file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (GSHELL-157) Dynamically adding / removing commands does not work well

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GSHELL-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guillaume Nodet resolved GSHELL-157.
------------------------------------

    Resolution: Fixed

Sending        gshell-wisdom/gshell-wisdom-core/src/main/java/org/apache/geronimo/gshell/wisdom/registry/CommandResolverImpl.java
Sending        gshell-wisdom/gshell-wisdom-core/src/main/java/org/apache/geronimo/gshell/wisdom/registry/GroupDirectoryResolver.java
Transmitting file data ..
Committed revision 741042.

> Dynamically adding / removing commands does not work well
> ---------------------------------------------------------
>
>                 Key: GSHELL-157
>                 URL: https://issues.apache.org/jira/browse/GSHELL-157
>             Project: GShell
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>            Reporter: Guillaume Nodet
>            Assignee: Guillaume Nodet
>             Fix For: 1.0-alpha-2
>
>
> When resolving commands, the command resolver uses a virtual file system.  Unfortunately, the data for virtual file systems is always cached, which means that removing a command will still make it available for resolution.  
> The cache problem is caused by the DelegateFileObject which does not refresh the underlying file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GSHELL-157) Dynamically adding / removing commands does not work well

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GSHELL-157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670710#action_12670710 ] 

Guillaume Nodet commented on GSHELL-157:
----------------------------------------

Sending        gshell-support/gshell-vfs/src/main/java/org/apache/geronimo/gshell/vfs/FileSystemAccessImpl.java
Sending        gshell-wisdom/gshell-wisdom-core/src/main/java/org/apache/geronimo/gshell/wisdom/registry/CommandResolverImpl.java
Sending        gshell-wisdom/gshell-wisdom-core/src/main/java/org/apache/geronimo/gshell/wisdom/registry/GroupDirectoryResolver.java
Transmitting file data ...
Committed revision 741069.

The previous commit did break things.  A better idea is to force a refresh on the underlying file when resolving a DelegateFileObject

> Dynamically adding / removing commands does not work well
> ---------------------------------------------------------
>
>                 Key: GSHELL-157
>                 URL: https://issues.apache.org/jira/browse/GSHELL-157
>             Project: GShell
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>            Reporter: Guillaume Nodet
>            Assignee: Guillaume Nodet
>             Fix For: 1.0-alpha-2
>
>
> When resolving commands, the command resolver uses a virtual file system.  Unfortunately, the data for virtual file systems is always cached, which means that removing a command will still make it available for resolution.  
> The cache problem is caused by the DelegateFileObject which does not refresh the underlying file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.