You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/12/08 23:09:44 UTC

[GitHub] [kafka] cmccabe commented on a diff in pull request #12965: KAFKA-14448 Let ZK brokers register with KRaft controller

cmccabe commented on code in PR #12965:
URL: https://github.com/apache/kafka/pull/12965#discussion_r1043907559


##########
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##########
@@ -53,7 +53,8 @@ import scala.jdk.CollectionConverters._
  */
 class BrokerLifecycleManager(val config: KafkaConfig,

Review Comment:
   can you use the standard style of
   ```
   foo(
     bar
     baz
     quux
   ) {
   }
   ```
   
   this code was written before we adopted that but if we're adding new parameters let's format it that way to avoid having so much indentation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org