[GitHub] [mynewt-core] vrahane commented on a change in pull request #1701: change multi byte instruction read write to single

[GitBox <gi...@apache.org>]

vrahane commented on a change in pull request #1701: change multi byte instruction read write to single
URL: https://github.com/apache/mynewt-core/pull/1701#discussion_r267044188
 
 

 ##########
 File path: hw/drivers/led/lp5523/src/lp5523.c
 ##########
 @@ -635,20 +634,32 @@ lp5523_get_engine_mapping(struct led_itf *itf, uint8_t engine,
 static int
 lp5523_set_pr_instruction(struct led_itf *itf, uint8_t addr, uint16_t *ins)
 {
-    uint8_t mem[2] = { ((*ins) >> 8) & 0x00ff, (*ins) & 0x00ff };
+    int rc;
+
+    uint8_t byte1[1] = { ((*ins) >> 8) & 0x00ff };
 
 Review comment:
   @kasjer you mean doesn't, correct ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services