[GitHub] rdhabalia commented on a change in pull request #706: Add missing lib instrunction for pulsar-ml-admin tool

[gi...@git.apache.org]

rdhabalia commented on a change in pull request #706: Add missing lib instrunction for pulsar-ml-admin tool
URL: https://github.com/apache/incubator-pulsar/pull/706#discussion_r134065973
 
 

 ##########
 File path: bin/pulsar-managed-ledger-admin
 ##########
 @@ -20,11 +20,19 @@
 
 import argparse
 import traceback
-from google.protobuf.text_format import Merge
-from google.protobuf.text_format import MessageToString
 import sys
-    
-from proto import MLDataFormats_pb2
+try:
+    from google.protobuf.text_format import Merge
+    from google.protobuf.text_format import MessageToString
+except Exception as missingLib:
+    sys.exit("You need python protobuf library. See: https://github.com/google/protobuf/tree/master/python")
 
 Review comment:
   yes, that would also work..I kept url if anyone wants to install specific tag/version. But, I think keeping `pip install protobuf` will look more simpler. will change it.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services