[GitHub] [ignite] timoninmaxim commented on a diff in pull request #10630: IGNITE-19252 The incremental snapshot restore operation fails if there is a node not from the baseline.

["timoninmaxim (via GitHub)" <gi...@apache.org>]

timoninmaxim commented on code in PR #10630:
URL: https://github.com/apache/ignite/pull/10630#discussion_r1160506943


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotRestoreProcess.java:
##########
@@ -1395,7 +1395,7 @@ private void finishCacheStop(UUID reqId, Map<UUID, Boolean> res, Map<UUID, Throw
      * @return Result future.
      */
     private IgniteInternalFuture<Boolean> incrementalSnapshotRestore(UUID reqId) {
-        if (ctx.clientNode())
+        if (ctx.clientNode() || !CU.baselineNode(ctx.discovery().localNode(), ctx.state().clusterState()))

Review Comment:
   Nice catch, thanks!
   
   I think we should use another check here. Let's check local node is included into `opCtx0.nodes()`. This collection bases on pre-defined discoCache, so it looks like it's more reliable way to verify node. WDYT?
   
   Also, I think we should check `opCtx0 != null` also. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org