You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "luizfna (via GitHub)" <gi...@apache.org> on 2023/05/10 22:12:28 UTC

[GitHub] [spark] luizfna commented on a diff in pull request #40984: [SPARK-43252][SQL] Rename the error class _LEGACY_ERROR_TEMP_2017 to UNRESOLVED_CUSTOM_CLASS

luizfna commented on code in PR #40984:
URL: https://github.com/apache/spark/pull/40984#discussion_r1190437858


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1599,6 +1599,11 @@
     },
     "sqlState" : "42703"
   },
+  "UNRESOLVED_CUSTOM_CLASS": {

Review Comment:
   In my opinion, it seems impossible to cause the error to occur unless the class is null. Also when I try I non existing class or a class not defined in the corresponding PATH I get: ClassNotFoundException. What do you guys think about letting the error without the class and maybe adjusting the message?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org