You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Noorul Islam K M <no...@github.com> on 2013/10/31 05:21:38 UTC
[jclouds-chef] Add checkstyle configuration and fix warnings. (#35)
You can merge this Pull Request by running:
git pull https://github.com/noorul/jclouds-chef checkstyle
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-chef/pull/35
-- Commit Summary --
* Add checkstyle configuration and fix warnings.
-- File Changes --
M core/src/main/java/org/jclouds/chef/config/ChefParserModule.java (6)
M core/src/main/java/org/jclouds/chef/domain/Attribute.java (2)
M core/src/main/java/org/jclouds/chef/domain/ChecksumStatus.java (2)
M core/src/main/java/org/jclouds/chef/domain/Client.java (2)
M core/src/main/java/org/jclouds/chef/domain/Resource.java (2)
M project/pom.xml (11)
A resources/checkstyle.xml (85)
-- Patch Links --
https://github.com/jclouds/jclouds-chef/pull/35.patch
https://github.com/jclouds/jclouds-chef/pull/35.diff
Re: [jclouds-chef] Add checkstyle configuration and fix warnings.
(#35)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-chef-pull-requests #93](https://jclouds.ci.cloudbees.com/job/jclouds-chef-pull-requests/93/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/35#issuecomment-27625061
Re: [jclouds-chef] Add checkstyle configuration and fix warnings.
(#35)
Posted by Andrew Phillips <no...@github.com>.
> Oh I see. I will wait then.
@noorul: https://github.com/jclouds/jclouds/pull/193 is merged. Could you remove the checkstyle config changes and update this PR? Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/35#issuecomment-27541196
Re: [jclouds-chef] Add checkstyle configuration and fix warnings.
(#35)
Posted by Ignasi Barrera <no...@github.com>.
This looks good, but the checkstyle configuration should be removed. The [config is taken from the classpath](https://github.com/jclouds/jclouds/blob/master/project/pom.xml#L675-L676) (to reuse them in all jclouds related projects), so once https://github.com/jclouds/jclouds/pull/193 is merged, the RedundantModifier confioguration should be available for jclouds-chef too.
The PR should only contain the chanes in the code, but not the configuration.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/35#issuecomment-27472238
Re: [jclouds-chef] Add checkstyle configuration and fix warnings.
(#35)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-chef #563](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-chef/563/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/35#issuecomment-27625102
Re: [jclouds-chef] Add checkstyle configuration and fix warnings.
(#35)
Posted by Andrew Phillips <no...@github.com>.
Thanks, @noorul! Let's see what BuildHive et. al. say...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/35#issuecomment-27598352
Re: [jclouds-chef] Add checkstyle configuration and fix warnings.
(#35)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-chef-pull-requests #90](https://jclouds.ci.cloudbees.com/job/jclouds-chef-pull-requests/90/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/35#issuecomment-27543769
Re: [jclouds-chef] Add checkstyle configuration and fix warnings.
(#35)
Posted by Andrew Phillips <no...@github.com>.
> jclouds-chef-pull-requests #93 SUCCESS
> jclouds » jclouds-chef #563 SUCCESS
There we go ;-) @nacx: Good to go for you too?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/35#issuecomment-27625322
Re: [jclouds-chef] Add checkstyle configuration and fix warnings.
(#35)
Posted by Andrew Phillips <no...@github.com>.
> Are we still waiting for buildhive?
I'm not sure whether the last change you made was caught by the PR builders...let's just try and see.
Thanks for the reminder!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/35#issuecomment-27625009
Re: [jclouds-chef] Add checkstyle configuration and fix warnings.
(#35)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-chef-pull-requests #88](https://jclouds.ci.cloudbees.com/job/jclouds-chef-pull-requests/88/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/35#issuecomment-27460425
Re: [jclouds-chef] Add checkstyle configuration and fix warnings.
(#35)
Posted by Noorul Islam K M <no...@github.com>.
Oh I see. I will wait then.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/35#issuecomment-27472868
Re: [jclouds-chef] Add checkstyle configuration and fix warnings.
(#35)
Posted by Noorul Islam K M <no...@github.com>.
Are we still waiting for buildhive?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/35#issuecomment-27620469
Re: [jclouds-chef] Add checkstyle configuration and fix warnings.
(#35)
Posted by Ignasi Barrera <no...@github.com>.
Merged. Thanks @noorul and @demobox !
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/35#issuecomment-27677071