[GitHub] [hadoop] steveloughran commented on pull request #5488: HADOOP-18012. ABFS: Using Source Path eTags for Rename Idemptonency checks

["steveloughran (via GitHub)" <gi...@apache.org>]

steveloughran commented on PR #5488:
URL: https://github.com/apache/hadoop/pull/5488#issuecomment-1490292881

   +1 pending the merge and checkstyle issues
   ```
   ./hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClientRenameResult.java:64:    return "AbfsClientRenameResult{" +:38: '+' should be on a new line. [OperatorWrap]
   ./hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClientRenameResult.java:65:        "op=" + op +:20: '+' should be on a new line. [OperatorWrap]
   ./hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClientRenameResult.java:66:        ", renameRecovered=" + renameRecovered +:48: '+' should be on a new line. [OperatorWrap]
   ./hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClientRenameResult.java:67:        ", isIncompleteMetadataState=" + isIncompleteMetadataState +:68: '+' should be on a new line. [OperatorWrap]
   ./hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java:343:    switch(client.getAuthType()) {: switch without "default" clause. [MissingSwitchDefault]
   ./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemDelegationSAS.java:29:import org.apache.hadoop.fs.azurebfs.utils.TracingContext;:8: Unused import - org.apache.hadoop.fs.azurebfs.utils.TracingContext. [UnusedImports]
   ```
   
   can you change this from draft to "ready for review" so I can merge this once you've done those


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org