You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/03/02 05:40:00 UTC

[jira] [Updated] (ARROW-7975) [C++] Do not include padding bytes in "Buffer" IPC metadata accounting

     [ https://issues.apache.org/jira/browse/ARROW-7975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated ARROW-7975:
----------------------------------
    Labels: pull-request-available  (was: )

> [C++] Do not include padding bytes in "Buffer" IPC metadata accounting
> ----------------------------------------------------------------------
>
>                 Key: ARROW-7975
>                 URL: https://issues.apache.org/jira/browse/ARROW-7975
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Wes McKinney
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.0.0
>
>
> At this line, we include the padding bytes into the IPC metadata
> https://github.com/apache/arrow/blob/apache-arrow-0.16.0/cpp/src/arrow/ipc/writer.cc#L192
> The effect of this is that buffer sizes are modified by an IPC roundtrip. According to the Format, the padding bytes do not need to be accounted for in the metadata. 
> https://github.com/apache/arrow/blob/master/format/Schema.fbs#L330
> The Java implementation, for example, does not.
> I ran into this when working on a prototype implementation of ARROW-300, where it is important to have the exact unpadded size of the original buffer that was written. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)