You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/09/02 06:33:47 UTC

Re: Review Request 37925: HIVE-11487: Add getNumPartitionsByFilter api in metastore api

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37925/#review97407
-----------------------------------------------------------


Akshay, it is hard to review with generated code put here. Can you update review request without any generated code?

- Amareshwari Sriramadasu


On Aug. 30, 2015, 8:41 p.m., Akshay Goyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37925/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2015, 8:41 p.m.)
> 
> 
> Review request for hive and Amareshwari Sriramadasu.
> 
> 
> Bugs: HIVE-11487
>     https://issues.apache.org/jira/browse/HIVE-11487
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Adding api for getting number of partitions for a filter. In order to be more optimal when only interested in the number. getAllPartitions will construct all the partition object which can be time consuming and not required.
> 
> 
> Diffs
> -----
> 
>   metastore/if/hive_metastore.thrift d651195e0477ee607657fec13b68ff3184ddbebf 
>   metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 520c6e3be0f0e329da9136738db4c591eac671c1 
>   metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 0354fe18111d5e4a360f90a45e67b7a11b7bd0e4 
>   metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 0afcf8ce7f250f99d0ebd6637db41faf10ddd95e 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AbortTxnRequest.java 37e5bf1a29006efcfc5620210f2613ecff1268bd 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddDynamicPartitions.java 9c78c49d383fa00980b1354f81d9f46965919467 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPartitionsRequest.java fcfaaf3a5cc630f499d70db05b4b3f8877d1091c 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPartitionsResult.java 9022019e901177581e96a9f0ca8d4ace6b84468f 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AggrStats.java 917cec0aee1afdacb3155d7beef05686689ab70b 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AlreadyExistsException.java d7a317b5e9f7d0d665c463d9e22c2700769abb8c 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/BinaryColumnStatsData.java 00b312d85466d55aedb78bc5015f8d8b88d3447e 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/BooleanColumnStatsData.java a0f3ab82a92b2fab66cc464411700b9f92675334 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/CheckLockRequest.java 82e30316d9545e9f44bfce93e453e078368f791e 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ColumnStatistics.java 510dace2a9b886aad53a4a45ce197d1f4a35a695 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ColumnStatisticsDesc.java cf967b6e25ca66a079980b34087b4e89635d0210 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ColumnStatisticsObj.java 3c2b1238aca7bb7e801267e772701e2d3c5b3044 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/CommitTxnRequest.java 5e8cd04f4923dd86548771725c047bf1bc29e2f9 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/CompactionRequest.java e9088e061f2e2e2fcf8bd706b12b0477cb4b2442 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ConfigValSecurityException.java 000670aaf1527df7227e334f63ed7f162f4fe9ec 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/CurrentNotificationEventId.java d55d87444e4ae4075ae892cd609d69baf35c011c 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java 56b72819f6a3c1747a15c4400039c32db38d3433 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Date.java 0b406d682fb5f877b021d39d8f263da348924912 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/DateColumnStatsData.java 7a3d4ed18e095bb8a49bc9d620693f3d53ce2e60 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Decimal.java 9215ce95deef33361d5b852121d938369b239d5c 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/DecimalColumnStatsData.java e64ca36ec524194e1181c4ecbda0dec427cc944c 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/DoubleColumnStatsData.java 2509ed567b7f57d72c29a14ce2380e98db44c545 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/DropPartitionsExpr.java 5e3a2d1f6bd85267a70e78da00745401ece9978f 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/DropPartitionsRequest.java 24536baf634fe14e9eb4981fd222df925aa1c855 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/DropPartitionsResult.java c139e6561986e544a0875efaff2aedb4844c39ca 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/EnvironmentContext.java 6accb8daafd98aa2c732fa1f437383562d215e4d 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FieldSchema.java ba69622d33f7d7d3965a59492aae3a98386335a8 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FireEventRequest.java f3d439cda9e1dfd6483b5d58cf63fd26e48694d2 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FireEventResponse.java d95ae06f3efe74bb3f01f010e5c9bd4c8f1971cf 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Function.java 50eff734eb4f8e903a6bbcd485d0cab653d282a4 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetAllFunctionsResponse.java 0a9e27b7659b6792eafc0104e298fa2677c4093e 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetOpenTxnsInfoResponse.java 61dea16f0817d73eb7ea9250c9adbc843137c0e1 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetOpenTxnsResponse.java bd21de5ad6be3483f2974a1ca2f5e6601c250bb5 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPrincipalsInRoleRequest.java 45e0cc13934d3b15400023a5c54819a44eb4f1f2 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPrincipalsInRoleResponse.java 805b898003722cf71c8ff87f7f2cc48e249037f9 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetRoleGrantsForPrincipalRequest.java c2c7259663619e61b9b9b8d010c395ac9ff04379 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetRoleGrantsForPrincipalResponse.java 7156665560d3bc60d7cf0cddf3c43ac313013803 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GrantRevokePrivilegeRequest.java 94e5a5e2617c4716969630e0b05fbb28096f8b6e 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GrantRevokePrivilegeResponse.java 1949aed8055191db1dd72b974a23ed260d7f5b53 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GrantRevokeRoleRequest.java ac3527a0bb2215731f46e16b3f6d3777d509ac6a 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GrantRevokeRoleResponse.java 81ae31f481fa0f9323d36c0dc61386c84952bd6a 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HeartbeatRequest.java 4a9ba7f06bea81253625ce9236e3fa6bed297439 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HeartbeatTxnRangeRequest.java dd6ed17463e7ecf24839aa93768c8d960e905e7b 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HeartbeatTxnRangeResponse.java 11bd82b86944cd5e0f77497ea2b6e25feed60bec 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HiveObjectPrivilege.java 931b4e1fba17d2bf9112987dc9b1573782f9cae1 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HiveObjectRef.java 2573cea99da299dbc7aa54bfd0a3e82b5cc2129b 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Index.java 81227c380ac80be705b5f6ce063ad5207a4f3f77 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/IndexAlreadyExistsException.java 50517edada042b9abcb81634d973cca3c2fc30be 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InsertEventRequestData.java 2e14cf912bf4e76212688871a8d5affd8dd7299f 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InvalidInputException.java 87e2f6b63b008dab05a8d926be83fb1c89b76c1e 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InvalidObjectException.java 14dd7d8ba502d3037489f046a0c09b6876e41a38 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InvalidOperationException.java 2e3f1e3985f547f077244cb7a85436a42b976edd 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InvalidPartitionException.java 1d9b56591c519bb6b1a426f9ca602a4babb66be5 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/LockComponent.java 319f8bb38d7c3b9cd203bd8b102e16db51694eb1 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/LockRequest.java 6894bfa9f447700cc5e37f457112d7175496d28b 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/LockResponse.java 08acaeb7017369d17a21d792b2bc53fbd72b5eef 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/LongColumnStatsData.java 93d2386e07eb69266e7de495ba49c7aeb92fa5ed 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/MetaException.java 883a1d497e7ea34644b1b6e6fd4e3590372426ee 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/NoSuchLockException.java e214b36895416579dd9b9d2a090d349093f7f093 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/NoSuchObjectException.java 1292a643aad334ec68b1c12f08c37116c0980192 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/NoSuchTxnException.java d1c430d0f6a9e1d09ceae090eb75e777e0068e43 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/NotificationEvent.java bcf4f51137569dbd997d61c603991b7166673476 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/NotificationEventRequest.java c2bc4e82e4c9d5bf91025c2c932e7ef30d46e9b8 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/NotificationEventResponse.java 24f9ce412f243c2d97540c112ec098087786d779 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/OpenTxnRequest.java c5f9ccf834e1d5ed3846fc455313aa58bd3c062d 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/OpenTxnsResponse.java c233422b491106f54ecdb84369eba959e5e54bc2 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Order.java da7bd55ba9d452ec59ae87daa6a088172f6af955 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Partition.java 224d28ed79687831ba850b753840161b6ffdf2be 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionListComposingSpec.java c50a1008964159df29669f47d53f8748f84eb83a 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionSpec.java b5251af234fd806f598032c471df26dd1bba6958 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionSpecWithSharedSD.java 5574e0be82b80aa46ea8f7380ce05eddbaf9ac8b 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionWithoutSD.java e1ec73e89d44aa7fae996956c9574bc09cd44f78 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsByExprRequest.java 6149c31fd70b6c8fa797ed799524ecc834ffefb3 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsByExprResult.java 740f7bda1e2c2e73b6eacbfc7ea3d3518d538aa4 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsStatsRequest.java 5d1ee87e3fda15dcb3b6857d877a02fd7e58feed 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsStatsResult.java da33014c6ff3985b26fb0952e387e0b63869cdf8 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrincipalPrivilegeSet.java 8f29f50c14bf9b05b5ff781811bb941ece1812da 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrivilegeBag.java 2fd819c4a45a226765cf47b6d50b7d2f39b524cf 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrivilegeGrantInfo.java c04e1969ad9a4cad4fdd432ab1a778b40a42ffc7 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ResourceUri.java 3b3df25c735ce64dbeb219e12ab9555445f0928e 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Role.java 5c882d2d8f16ae36953b56df3c430a6adf56ba9b 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/RolePrincipalGrant.java c4beb08f9d54ffc149a99fbc2453e7220d3a0c29 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Schema.java 8772180557073ef17a70732419ca1ced6ce1e7ad 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SerDeInfo.java b30e698e59a9cb6bd1f80bfdc86d4c0e40ab88a0 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SetPartitionsStatsRequest.java 7da298c8018b3c08dd7eeaf6051669673e6312aa 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowCompactRequest.java 775638496dd462d8cabc512b35012ff5a2b60071 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowCompactResponse.java dd1e85751fd326ea1f2c0d7d4bff28f787b6490e 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowCompactResponseElement.java cd7e79eb55ec8c8b900939db09906aa567c2b5ab 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowLocksRequest.java 122c070c658e2de668c611250b88cc566fea6a11 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowLocksResponse.java 52b0bbc8572fbd2fe1d93f0436cc07e41dd2653d 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowLocksResponseElement.java 8be9b0579724a763e95653d7d6ed897840ebabad 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SkewedInfo.java bc644952c85be7a530f48b21aa798b212016763d 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/StorageDescriptor.java 165a8791a18b9752f791d6d1e6723f0e40efb158 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/StringColumnStatsData.java 9906ff35a42758dfdaf6af35b51396c1ac84b6f3 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java 51b9e38528b2848cd3a5371802c642e259fabd97 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TableStatsRequest.java 1edcaf998fbb3223d80d13f3f376f33c41aa9969 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TableStatsResult.java 25a1f2507bb78f0563372688b322ae0d2e3a8d02 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java cdbae95c886ceb405b3b9cc28e9b8bfd3ee8c9a3 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TxnAbortedException.java a877338d3d28c53ae596d149952ce1c537feda1f 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TxnInfo.java 8b255b931c3ab74168be836c85906fcb6cc6859c 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TxnOpenException.java 05af505a2de59a6846bd33f4a4287efffb7df0b0 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Type.java 61e7cebf29a081880906d528d66ddf8e69b98c19 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/UnknownDBException.java e05e79d2b6e81a9084f3f274f00048a0e42e06c1 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/UnknownPartitionException.java c626bf68ed49ee51000fe9425c90213fb88ba249 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/UnknownTableException.java 2856121a80e7192635eede2935b0b3c4507d079f 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/UnlockRequest.java cf248e0c24dc87a9961e7eb1cc625051b3c60de5 
>   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Version.java cc8d5f5ecc0119776f531f173a30d4ce01bea2f8 
>   metastore/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php ae47cb5ddd19ab963dd78b8b28f23ff7d67802d7 
>   metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote dc348efab5e0177f89ee83a94591679da8f3a1dc 
>   metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 9e460f000d7d4ce5fea3d99b32a5694f389a46e2 
>   metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 73a1d20aff63d0a4789794bb1720d678c98ae316 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1840e76cc567e95e1942d912b8ab0db516d63a3b 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 482f27851c0732604cdb04e9a0b981757643210b 
>   metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 5fde6d34bff7fd091b3ca36472d929269660c9b9 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 522fcc275f42a3b75af9f4bee9bf1ab3cd70364b 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java d165fc82386eafa5200068f5c56a9e98788627aa 
>   metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 7c85eea21375f349f88e918329030364acca2771 
>   metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java f184c568b5eb5b16f239c6128f1ad20bd83957cb 
>   metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 83fb4bb900a51101d8c411d199357c8ddd29486e 
>   ql/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/ql/plan/api/Adjacency.java 5ea9b6ea429aad8153bbcb4e7844ce6131255259 
>   ql/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/ql/plan/api/Graph.java e621cfa146dbe30b7cdea91d3cc318916135185f 
>   ql/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/ql/plan/api/Operator.java 1b18aabd39f0aa53db036fc045b4df87f325b3a3 
>   ql/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/ql/plan/api/Query.java 5c5e0f8acff782c168ca7e72c81810bfe7325bd2 
>   ql/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/ql/plan/api/QueryPlan.java d340d582100e0e79440ac0f00e6ca12052c4a118 
>   ql/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/ql/plan/api/Stage.java 73539336575055540e747d6a8ff9d0fb87e5e693 
>   ql/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/ql/plan/api/Task.java 09a2e7f648b21d7b7ad74c6d476f4db612cb3b08 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 396c07044ec69d8b74e38fb156333b6eb35b9f4d 
>   serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/InnerStruct.java db325affefc7360d24daafbaf0c8d240ff65a9cd 
>   serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java 1232ff9a2cc149bda8f5a309d46e69a4bbef0fe2 
>   serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java 4d2f5bfcd1bf29f7b29e9a11c0779ff11e2e2ccb 
>   serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/IntString.java 23d7363e0e4c858d77d7dc467d2a2605e1f7be92 
>   serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java 94477084a600cb03f3967d41894c9a7cc0a6d1fe 
>   serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MiniStruct.java d8c46f45d1ed015bb0557a532af78f12b2f032ce 
>   serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/SetIntString.java 58498b0a98836e4cf72b4029beaf90448cf2e470 
>   service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/HiveClusterStatus.java d4b697285585216de48c706f1df2bcf31db9e92d 
>   service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/HiveServerException.java 760c81e090bcfd6162529f866c525865f3a505b4 
>   service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/ThriftHive.java df793b18439c1aa53cb6d56395d7a85cb304010f 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TArrayTypeEntry.java 56255167942bdcd448ec45f582376a80a568dcea 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TBinaryColumn.java 202399af7911dea7b2b3e71341e8728b413141ce 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TBoolColumn.java 921e9de74753b343f542e4bb0c8abfc59491769e 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TBoolValue.java 201c9fb25731a28ed22a07e785dd92fc2ff8ca31 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TByteColumn.java cd9b6da192ba20dfbc59402de01ce20e2a5476ed 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TByteValue.java 42b5bd530f73db4c1567741179ebcff2c08614b1 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCLIService.java 6bdd53d3811acf5bcd8f66b9b59bea1d61becde3 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCancelDelegationTokenReq.java 1097869302f306e396cf871145b4fac51f7da406 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCancelDelegationTokenResp.java 546910848997b2bac295d57a2d6fa6eb57b16ef7 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCancelOperationReq.java 83d191e969b67a73f124cb814e6ba00e9e78ab7f 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCancelOperationResp.java b8d96df326d16ccc254c65432367cf76a269a85c 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCloseOperationReq.java ca688667f49499866efdecf315cc99d36b0f3d71 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCloseOperationResp.java 092e7e4cd56b22c5f17f2fe0187964794032063e 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCloseSessionReq.java a5d910f9fb32687429ae2c59d08e8e28961941b0 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCloseSessionResp.java ae4b554c78b03f13391700b6635dd2badaecafa8 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TColumnDesc.java e31aa815e1293042d52c3aec813a0dc6f6314540 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TDoubleColumn.java 7236d9005de965f1931c1cf1f1e80e3a4846eaaa 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TDoubleValue.java 4b0811e463a81820563740759df8cc7192297983 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TExecuteStatementReq.java feaed346cf983101502ab7c95c6f1ede0ed0e154 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TExecuteStatementResp.java daf7b5ca263f2ffda490b2fc44c34474af19b859 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TFetchResultsReq.java 47d9a0b86f90943a2699a2c1588ec875cdba7f34 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TFetchResultsResp.java b9f3ef6f683ca4f6647a7a500ac40f4e66a7c6a7 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetCatalogsReq.java 0e63b9a5ac18d5f076832006915c55dc64f8199d 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetCatalogsResp.java 7067ff768f3d2cd93266bb81c6c18ffa7fc9b704 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetColumnsReq.java a153968e01729656a1e59733b724948927ea7e6a 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetColumnsResp.java 49ecb98e9968a012968f495a4497fada3fbe2f0e 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetDelegationTokenReq.java 2c2fa0f6ddfa29aff4ab43e1c68d067495ef327a 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetDelegationTokenResp.java 422200549e2f33a39bb931c7ff0a24d42ca2a997 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetFunctionsReq.java 5bc054065dea86066bc3bbd5fd4007d88f2b86a9 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetFunctionsResp.java a64c9489fddae1ac1dc4f503f4bfbf864ec4ac15 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetInfoReq.java 7dd6a1462c91cfe113af02747f13f741b2b9b68c 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetInfoResp.java 3e16318987c2518aa5f80827c64e271c40b985cc 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetOperationStatusReq.java f4d5faee71555a07c290c623cbfc27153631fbc2 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetOperationStatusResp.java 897f7f52f03006110a6889d48b653b8797fceec0 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetResultSetMetadataReq.java 405ffc618a21618c5b9a1dd43e024dc95aff9119 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetResultSetMetadataResp.java 37353107e9a383d130fd27c600a1c6d68eeea914 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetSchemasReq.java 33088b406b258d33d66cc72f8b2d099c7b9dd460 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetSchemasResp.java ec598a3ddd7deda5d2754d96ff0e7fde5ce30186 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetTableTypesReq.java 3e09a644cd18b17400edb2d7019c27c74ef4a5b6 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetTableTypesResp.java cdba9b535f0d19f22756e2d805aa7f92b2f6a5d1 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetTablesReq.java 805e69fabf8d43e4d17ef7962e92bb2ea9802c03 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetTablesResp.java 0d03dd87be5fe2a512759601738e7640888ec299 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetTypeInfoReq.java 0628e214a69df9c648942a7016b4e16567bde56f 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetTypeInfoResp.java 60588262ae14a863564129843a52fc08e86a2c55 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/THandleIdentifier.java f20c4d00d9936367f107c69d4813fa11d0c9a76a 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TI16Column.java 267d10907c6fa087cc8be77004375c331cf87fe3 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TI16Value.java ddaf9ef5756e6dc1e8994aedf888a5981e5d88dd 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TI32Column.java c79df4fd3836f27ce1533b9e5ac414da04cf72af 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TI32Value.java d521373b9714418a17f4a8452e4fd236f0ea256a 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TI64Column.java 746ade201f72b3f28a209bca3aeec32c4dee4c78 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TI64Value.java b419b8011cdd0e3b3d9eac795f521758a345f4a8 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TMapTypeEntry.java 91a85ef7b9035588c89433a9152ad4f37a240103 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionReq.java 657f8682825f06293ccfbeb7d3a74cd65eea3d6e 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionResp.java 48f4b452ae3fe5f74e2b918ea4022c55099189ad 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOperationHandle.java db4111796e77747d00373f72abb090916690f12b 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TPrimitiveTypeEntry.java f1c8d5825445fe96d2194d59f5efc193405cb7fa 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRenewDelegationTokenReq.java 91f8b00d6368500628ec0c5865fc7ea0f8cc59e1 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRenewDelegationTokenResp.java c01cc3fdc42ae5ca83a484e60ddf308429b3a097 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRow.java 197bab6226b40ca580f70de999843f707bff7a80 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRowSet.java cc1a14823da427f987324e0378277284e31aba7f 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TSessionHandle.java 264e155ba7b22f8c6ac3f5535902c5ac88a5f02e 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TStatus.java 1cd7980136630e6511c6087bd662b2a438b89182 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TStringColumn.java d996529ed704696ae3c047fb2ab3042e4353efdd 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TStringValue.java 9655f382f75980258eee4dbed501487cdac9774f 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TStructTypeEntry.java d58184ca98543955221d099f2ffee33610397ba6 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TTableSchema.java 796b73b5a00a15c92d9b06a461fc00df1033b9e6 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TTypeDesc.java 95b4466970785ca4dc02c8df0f49a2c1da358b54 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TTypeQualifiers.java 15ac5a94ec6a9ccc1cf422cffaa7d8ffa3dd3d2b 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TUnionTypeEntry.java eccf3037b3bb70b692b7bffe6d2ece5a3ade3214 
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TUserDefinedTypeEntry.java 21da61b5c098ecaa304278a2e03becfb5f876faf 
>   service/src/gen/thrift/gen-py/hive_service/ThriftHive-remote 747c2bea4d435f32f02208e822b64ed14dbf984e 
> 
> Diff: https://reviews.apache.org/r/37925/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akshay Goyal
> 
>


Re: Review Request 37925: HIVE-11487: Add getNumPartitionsByFilter api in metastore api

Posted by Akshay Goyal <ak...@gmail.com>.

> On Sept. 2, 2015, 4:33 a.m., Amareshwari Sriramadasu wrote:
> > Akshay, it is hard to review with generated code put here. Can you update review request without any generated code?

Updated.


- Akshay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37925/#review97407
-----------------------------------------------------------


On Sept. 2, 2015, 11:14 a.m., Akshay Goyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37925/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2015, 11:14 a.m.)
> 
> 
> Review request for hive and Amareshwari Sriramadasu.
> 
> 
> Bugs: HIVE-11487
>     https://issues.apache.org/jira/browse/HIVE-11487
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Adding api for getting number of partitions for a filter. In order to be more optimal when only interested in the number. getAllPartitions will construct all the partition object which can be time consuming and not required.
> 
> 
> Diffs
> -----
> 
>   metastore/if/hive_metastore.thrift d651195e0477ee607657fec13b68ff3184ddbebf 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1840e76cc567e95e1942d912b8ab0db516d63a3b 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 482f27851c0732604cdb04e9a0b981757643210b 
>   metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 5fde6d34bff7fd091b3ca36472d929269660c9b9 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 522fcc275f42a3b75af9f4bee9bf1ab3cd70364b 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java d165fc82386eafa5200068f5c56a9e98788627aa 
>   metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 7c85eea21375f349f88e918329030364acca2771 
>   metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java f184c568b5eb5b16f239c6128f1ad20bd83957cb 
>   metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 83fb4bb900a51101d8c411d199357c8ddd29486e 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 396c07044ec69d8b74e38fb156333b6eb35b9f4d 
> 
> Diff: https://reviews.apache.org/r/37925/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akshay Goyal
> 
>