You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2014/05/19 15:58:21 UTC
Re: Review Request 21632: Views: Pig view parameters adjusting (Roman Rader
via tbeerbower)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21632/
-----------------------------------------------------------
(Updated May 19, 2014, 1:58 p.m.)
Review request for Ambari and Tom Beerbower.
Summary (updated)
-----------------
Views: Pig view parameters adjusting (Roman Rader via tbeerbower)
Bugs: AMBARI-5786
https://issues.apache.org/jira/browse/AMBARI-5786
Repository: ambari
Description
-------
1) Rename dataworker.hdfs_user -> dataworker.hdfs.username
Use this as HDFS user (if provided)
2) Remove dataworker.use_current_user parameter
3) Add dataworker.username and use it in generating paths for scripts and jobs status directories (if not provided then use context.getUsername())
4) Rename dataworker.templeton_url -> dataworker.webhcat.url
and dataworker.templeton_user -> dataworker.webhcat.user
Diffs
-----
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/PersonalCRUDResourceManager.java 650d9a2
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/jobs/JobResourceManager.java abc2ddd
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/scripts/ScriptResourceManager.java f98bdab
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/services/BaseService.java 06e00c2
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/templeton/client/TempletonApi.java 4fe61cd
contrib/views/pig/src/main/resources/view.xml dd10198
contrib/views/pig/src/test/java/org/apache/ambari/view/pig/BasePigTest.java 7352157
contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/JobTest.java 6cf4bd7
contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/ScriptTest.java e7ddf3d
contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/ScriptTestHDFSUnmanaged.java 9eacbee
contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/ScriptTestUnmanaged.java a6138b5
Diff: https://reviews.apache.org/r/21632/diff/
Testing
-------
New unit tests. All view tests pass...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Contrib Views .............................. SUCCESS [1.574s]
[INFO] Files ............................................. SUCCESS [2:01.523s]
[INFO] Pig ............................................... SUCCESS [1:04.320s]
[INFO] Slider ............................................ SUCCESS [1:44.496s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 4:53.621s
[INFO] Finished at: Mon May 19 09:55:30 EDT 2014
[INFO] Final Memory: 28M/81M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
Re: Review Request 21632: Views: Pig view parameters adjusting (Roman Rader
via tbeerbower)
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21632/#review43360
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On May 19, 2014, 1:58 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21632/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 1:58 p.m.)
>
>
> Review request for Ambari and Tom Beerbower.
>
>
> Bugs: AMBARI-5786
> https://issues.apache.org/jira/browse/AMBARI-5786
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1) Rename dataworker.hdfs_user -> dataworker.hdfs.username
> Use this as HDFS user (if provided)
> 2) Remove dataworker.use_current_user parameter
> 3) Add dataworker.username and use it in generating paths for scripts and jobs status directories (if not provided then use context.getUsername())
> 4) Rename dataworker.templeton_url -> dataworker.webhcat.url
> and dataworker.templeton_user -> dataworker.webhcat.user
>
>
> Diffs
> -----
>
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/PersonalCRUDResourceManager.java 650d9a2
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/jobs/JobResourceManager.java abc2ddd
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/scripts/ScriptResourceManager.java f98bdab
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/services/BaseService.java 06e00c2
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/templeton/client/TempletonApi.java 4fe61cd
> contrib/views/pig/src/main/resources/view.xml dd10198
> contrib/views/pig/src/test/java/org/apache/ambari/view/pig/BasePigTest.java 7352157
> contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/JobTest.java 6cf4bd7
> contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/ScriptTest.java e7ddf3d
> contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/ScriptTestHDFSUnmanaged.java 9eacbee
> contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/ScriptTestUnmanaged.java a6138b5
>
> Diff: https://reviews.apache.org/r/21632/diff/
>
>
> Testing
> -------
>
> New unit tests. All view tests pass...
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Contrib Views .............................. SUCCESS [1.574s]
> [INFO] Files ............................................. SUCCESS [2:01.523s]
> [INFO] Pig ............................................... SUCCESS [1:04.320s]
> [INFO] Slider ............................................ SUCCESS [1:44.496s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 4:53.621s
> [INFO] Finished at: Mon May 19 09:55:30 EDT 2014
> [INFO] Final Memory: 28M/81M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>