[jira] [Commented] (METRON-1670) Stellar WEEK_OF_YEAR test is locale sensitive

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543854#comment-16543854 ] 

ASF GitHub Bot commented on METRON-1670:
----------------------------------------

GitHub user simonellistonball opened a pull request:

    https://github.com/apache/metron/pull/1104

    METRON-1670 Stellar WEEK_OF_YEAR test is locale sensitive

    ## Contributor Comments
    Tests were previously not local sensitive.
    
    Used a locale sensitive Calendar instance to create ground truth on WeekOfYear test
    
    To test, run the tests of a US Locale and a GB Locale. Both should now pass, previously GB locale failed. 
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/simonellistonball/metron METRON-1670

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1104
    
----
commit bafd3827d273c5c33b4293fd338595b8de3a75b2
Author: Simon Elliston Ball <si...@...>
Date:   2018-07-13T22:57:59Z

    Used a locale sensitive Calendar instance to create ground truth on WeekOfYear test

----


> Stellar WEEK_OF_YEAR test is locale sensitive
> ---------------------------------------------
>
>                 Key: METRON-1670
>                 URL: https://issues.apache.org/jira/browse/METRON-1670
>             Project: Metron
>          Issue Type: Bug
>    Affects Versions: 0.5.0
>            Reporter: Simon Elliston Ball
>            Priority: Trivial
>
> The Stellar WEEK_OF_YEAR(epoch) function is sensitive to the locale of the machine it is running on. The tests in DateFunctionsTest are not, this leads to test failures on machine locales that differ in their first day of week definition or days in first week definition.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)