You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/10/29 21:41:29 UTC

[GitHub] [guacamole-client] necouchman commented on pull request #546: GUACAMOLE-1123: Standardize REST endpoints for historical data

necouchman commented on pull request #546:
URL: https://github.com/apache/guacamole-client/pull/546#issuecomment-719040678


   > It sounds like everything is pretty much there (or about to be there). Let me know when you want me to dive back in. I'm guessing it's no longer draft at this point?
   
   Yeah, I think it's pretty close, now.  Feel free to give it another look and see what else is missing. I'm still not 100% sure about the `ConnectionRecordMapper` and `UserRecordMapper` changes, specifically whether the `AND` is implicit, so that's probably worth a little more legwork on my part to make sure we don't introduce any bugs with that change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org