You are viewing a plain text version of this content. The canonical link for it is here.
Posted to woden-dev@ws.apache.org by "Jeff MAURY (JIRA)" <ji...@apache.org> on 2008/06/13 17:18:45 UTC

[jira] Created: (WODEN-209) equals method should be implemented for the WSDL2.0 components

equals method should be implemented for the WSDL2.0 components
--------------------------------------------------------------

                 Key: WODEN-209
                 URL: https://issues.apache.org/jira/browse/WODEN-209
             Project: Woden
          Issue Type: Improvement
          Components: Parser
            Reporter: Jeff MAURY


The equals method should be implemented on the WSDL2.0 components (Description, Binding, Interface, ....). As of June 2008, they rely on Object.equals which is not relevant because it does not compare the content of the object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org


[jira] Updated: (WODEN-209) equals method should be implemented for the WSDL2.0 components

Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WODEN-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Kaputin updated WODEN-209:
-------------------------------

    Fix Version/s: M9

> equals method should be implemented for the WSDL2.0 components
> --------------------------------------------------------------
>
>                 Key: WODEN-209
>                 URL: https://issues.apache.org/jira/browse/WODEN-209
>             Project: Woden
>          Issue Type: Improvement
>          Components: Parser
>            Reporter: Jeff MAURY
>            Assignee: John Kaputin
>             Fix For: M9
>
>         Attachments: woden209.patch.txt
>
>
> The equals method should be implemented on the WSDL2.0 components (Description, Binding, Interface, ....). As of June 2008, they rely on Object.equals which is not relevant because it does not compare the content of the object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org


[jira] Updated: (WODEN-209) equals method should be implemented for the WSDL2.0 components

Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WODEN-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Kaputin updated WODEN-209:
-------------------------------

    Attachment: woden209.patch.txt

Per discussion on the mailing list:
http://mail-archives.apache.org/mod_mbox/ws-woden-dev/200807.mbox/%3cOF208BF3CE.1071CC66-ON8525747F.006169D9-8525747F.0061A2A6@ca.ibm.com%3e

I have re-implemented the existing logical equivalence checking of WSDL2 components in a new method 'isEquivalentTo', to replace the equals methods declared on WSDLComponent (the equals method has been deprecated in the API, to be removed later).

The changes have been committed to the woden209 branch in SVN for peer review, prior to merging the changes to trunk. Note, that there is still more equivalence checking to be implemented, as before. For the time being, I have just replaced the existing equivalence checking (which was done via WSDLComponent.equals) with WSDLComponent.isEquivalentTo.

A patch file of these changes has been attached to this JIRA.

> equals method should be implemented for the WSDL2.0 components
> --------------------------------------------------------------
>
>                 Key: WODEN-209
>                 URL: https://issues.apache.org/jira/browse/WODEN-209
>             Project: Woden
>          Issue Type: Improvement
>          Components: Parser
>            Reporter: Jeff MAURY
>            Assignee: John Kaputin
>         Attachments: woden209.patch.txt
>
>
> The equals method should be implemented on the WSDL2.0 components (Description, Binding, Interface, ....). As of June 2008, they rely on Object.equals which is not relevant because it does not compare the content of the object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org


[jira] Resolved: (WODEN-209) equals method should be implemented for the WSDL2.0 components

Posted by "Sagara Gunathunga (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WODEN-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sagara Gunathunga  resolved WODEN-209.
--------------------------------------

    Resolution: Fixed
      Assignee: Sagara Gunathunga   (was: John Kaputin)

fixed in trunk 

> equals method should be implemented for the WSDL2.0 components
> --------------------------------------------------------------
>
>                 Key: WODEN-209
>                 URL: https://issues.apache.org/jira/browse/WODEN-209
>             Project: Woden
>          Issue Type: Improvement
>          Components: Parser
>            Reporter: Jeff MAURY
>            Assignee: Sagara Gunathunga 
>             Fix For: M9
>
>         Attachments: woden209.patch.txt
>
>
> The equals method should be implemented on the WSDL2.0 components (Description, Binding, Interface, ....). As of June 2008, they rely on Object.equals which is not relevant because it does not compare the content of the object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org


[jira] Commented: (WODEN-209) equals method should be implemented for the WSDL2.0 components

Posted by "Jeremy Hughes (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WODEN-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624812#action_12624812 ] 

Jeremy Hughes commented on WODEN-209:
-------------------------------------

Hi John, I couldn't see the @deprecated tags so I just added them. Looks good. +1 from me for merging into the trunk.

> equals method should be implemented for the WSDL2.0 components
> --------------------------------------------------------------
>
>                 Key: WODEN-209
>                 URL: https://issues.apache.org/jira/browse/WODEN-209
>             Project: Woden
>          Issue Type: Improvement
>          Components: Parser
>            Reporter: Jeff MAURY
>            Assignee: John Kaputin
>             Fix For: M9
>
>         Attachments: woden209.patch.txt
>
>
> The equals method should be implemented on the WSDL2.0 components (Description, Binding, Interface, ....). As of June 2008, they rely on Object.equals which is not relevant because it does not compare the content of the object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org


[jira] Commented: (WODEN-209) equals method should be implemented for the WSDL2.0 components

Posted by "Sagara Gunathunga (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WODEN-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749943#action_12749943 ] 

Sagara Gunathunga  commented on WODEN-209:
------------------------------------------

revision: 810092

Found changes on following files and merged them into the trunk.

1. WSDLComponent.java
2. WSDLComponentValidator.java
3. Interface1009.java
4. WSDLComponentImpl.java
5. InterfaceImpl.java

Also I think we need to add/improve some Test Cases  to test this behavior.  

> equals method should be implemented for the WSDL2.0 components
> --------------------------------------------------------------
>
>                 Key: WODEN-209
>                 URL: https://issues.apache.org/jira/browse/WODEN-209
>             Project: Woden
>          Issue Type: Improvement
>          Components: Parser
>            Reporter: Jeff MAURY
>            Assignee: John Kaputin
>             Fix For: M9
>
>         Attachments: woden209.patch.txt
>
>
> The equals method should be implemented on the WSDL2.0 components (Description, Binding, Interface, ....). As of June 2008, they rely on Object.equals which is not relevant because it does not compare the content of the object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org


[jira] Commented: (WODEN-209) equals method should be implemented for the WSDL2.0 components

Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WODEN-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623663#action_12623663 ] 

John Kaputin commented on WODEN-209:
------------------------------------

r687040
Committed changes described above to the woden209 branch.

> equals method should be implemented for the WSDL2.0 components
> --------------------------------------------------------------
>
>                 Key: WODEN-209
>                 URL: https://issues.apache.org/jira/browse/WODEN-209
>             Project: Woden
>          Issue Type: Improvement
>          Components: Parser
>            Reporter: Jeff MAURY
>            Assignee: John Kaputin
>         Attachments: woden209.patch.txt
>
>
> The equals method should be implemented on the WSDL2.0 components (Description, Binding, Interface, ....). As of June 2008, they rely on Object.equals which is not relevant because it does not compare the content of the object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org


[jira] Assigned: (WODEN-209) equals method should be implemented for the WSDL2.0 components

Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WODEN-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Kaputin reassigned WODEN-209:
----------------------------------

    Assignee: John Kaputin

> equals method should be implemented for the WSDL2.0 components
> --------------------------------------------------------------
>
>                 Key: WODEN-209
>                 URL: https://issues.apache.org/jira/browse/WODEN-209
>             Project: Woden
>          Issue Type: Improvement
>          Components: Parser
>            Reporter: Jeff MAURY
>            Assignee: John Kaputin
>
> The equals method should be implemented on the WSDL2.0 components (Description, Binding, Interface, ....). As of June 2008, they rely on Object.equals which is not relevant because it does not compare the content of the object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org