You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/14 08:01:01 UTC
[GitHub] [airflow] msumit commented on a change in pull request #16411: generate go client with latest openapi generator template
msumit commented on a change in pull request #16411:
URL: https://github.com/apache/airflow/pull/16411#discussion_r650427627
##########
File path: clients/gen/go.sh
##########
@@ -25,7 +25,7 @@ readonly CLEANUP_DIRS
# shellcheck source=./clients/gen/common.sh
source "${CLIENTS_GEN_DIR}/common.sh"
-VERSION=1.1.0
+VERSION=2.0.0
Review comment:
Shouldn't it be `2.1.0`?
##########
File path: clients/gen/go.sh
##########
@@ -25,7 +25,7 @@ readonly CLEANUP_DIRS
# shellcheck source=./clients/gen/common.sh
source "${CLIENTS_GEN_DIR}/common.sh"
-VERSION=1.1.0
+VERSION=2.0.0
Review comment:
Nop, we decided to use Major.Minor release numbers from the Airflow and only last digit denoting fixes done on the client.
##########
File path: clients/gen/go.sh
##########
@@ -25,7 +25,7 @@ readonly CLEANUP_DIRS
# shellcheck source=./clients/gen/common.sh
source "${CLIENTS_GEN_DIR}/common.sh"
-VERSION=1.1.0
+VERSION=2.0.0
Review comment:
@potiuk it was on the dev mailing list ([here](https://lists.apache.org/thread.html/r8b7f615f56eaa6d5c1955173295d70b47e038b92b84310a82e2765a9%40%3Cdev.airflow.apache.org%3E)).. I don't think that we've added it somewhere in the docs yet..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org