[GitHub] [spark] beliefer commented on a change in pull request #28641: [SPARK-31824][CORE][TESTS] DAGSchedulerSuite: Improve and reuse completeShuffleMapStageSuccessfully

[GitBox <gi...@apache.org>]

beliefer commented on a change in pull request #28641:
URL: https://github.com/apache/spark/pull/28641#discussion_r435070559



##########
File path: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -889,16 +870,40 @@ class DAGSchedulerSuite extends SparkFunSuite with LocalSparkContext with TimeLi
    * @param stageId - The current stageId
    * @param attemptIdx - The current attempt count
    * @param numShufflePartitions - The number of partitions in the next stage
+   * @param taskSetOpt - The index of task set
+   * @param hostNames - Host on which each task in the task set is executed
+   * @param mapTaskIds - ID of each task in the task set
+   * @param execIds - ID of the executor in which each task in the task set is executed
    */
   private def completeShuffleMapStageSuccessfully(

Review comment:
       @Ngone51 Thanks! Only two test cases passed maptaskids. I will delete this parameter.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org