You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by alasdairhodge <gi...@git.apache.org> on 2015/12/10 13:30:13 UTC
[GitHub] incubator-brooklyn pull request: Misc MySQL 5.5.x and 5.6.x fixes
GitHub user alasdairhodge opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1098
Misc MySQL 5.5.x and 5.6.x fixes
Remaining issues:
* 5.7.x introduces breaking changes in certain command/script behaviours, notably `mysql_install_db`, which is invoked during `customize`
* 5.5.x and 5.6.x working on Ubuntu but failing on default AWS Red Hat / Amazon Linux image due to missing perl dependencies
Will address these in subsequent PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alasdairhodge/incubator-brooklyn mysql-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1098.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1098
----
commit 6fcc0e623208a803abb01124384f4b1e91c2b34a
Author: Alasdair Hodge <gi...@alasdairhodge.co.uk>
Date: 2015-12-09T11:22:04Z
Derive artefact and directory names from download URL.
commit c2088db62faf1e0f9e3a34b5b03a540a9a88268f
Author: Alasdair Hodge <gi...@alasdairhodge.co.uk>
Date: 2015-12-09T11:22:47Z
Atomic sensor test-and-set.
commit 3e6398740489bd67cc3901d9892eff799a2690d6
Author: Alasdair Hodge <gi...@alasdairhodge.co.uk>
Date: 2015-12-09T12:57:11Z
Derive correct URL path for specified version.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Misc MySQL 5.5.x and 5.6.x fixes
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1098#issuecomment-163928458
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Misc MySQL 5.5.x and 5.6.x fixes
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1098
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Misc MySQL 5.5.x and 5.6.x fixes
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1098#discussion_r47368496
--- Diff: software/database/src/main/java/org/apache/brooklyn/entity/database/mysql/MySqlNodeImpl.java ---
@@ -135,8 +135,8 @@ protected void disconnectSensors() {
public int getPort() {
return getAttribute(MYSQL_PORT);
}
-
- public String getSocketUid() {
+
+ public synchronized String getSocketUid() {
--- End diff --
Post merge comment... I'd have preferred if we'd declared a `private final Object mutex` to synchronize on. This is probably ok, but in general I don't like synchronizing on `this` in case other threads/callers have synchronized on this in other situations. No strong feelings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---