You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/01/05 14:36:08 UTC

[GitHub] [incubator-dolphinscheduler] Jave-Chen opened a new pull request #1721: Fix bug: NullPointerException etc.

Jave-Chen opened a new pull request #1721: Fix bug: NullPointerException etc.
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1721
 
 
   ## What is the purpose of the pull request
   #1720 Fix bug: NullPointerException etc.
   
   ## Brief change log
   1. NullPointerException 
   -  Add null check
   2. Use try-with-resources or close this "Scanner" in a "finally" clause.
   - Add try-with-resources on FSDataInputStream 
   3. Not enough arguments.
   - Add argument with string.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1721: Fix bug: NullPointerException etc.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1721: Fix bug: NullPointerException etc.
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1721#issuecomment-570918714
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=h1) Report
   > Merging [#1721](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/1f7db8f7975d2d01048eaaeae98d4425417abbae?src=pr&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `3.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##              dev    #1721      +/-   ##
   ==========================================
   - Coverage   17.48%   17.47%   -0.02%     
   ==========================================
     Files         285      285              
     Lines       13912    13926      +14     
     Branches     2274     2279       +5     
   ==========================================
     Hits         2433     2433              
   - Misses      11206    11219      +13     
   - Partials      273      274       +1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...g/apache/dolphinscheduler/dao/utils/DagHelper.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3V0aWxzL0RhZ0hlbHBlci5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
   | [.../dolphinscheduler/api/service/ExecutorService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRXhlY3V0b3JTZXJ2aWNlLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
   | [...che/dolphinscheduler/alert/runner/AlertSender.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9ydW5uZXIvQWxlcnRTZW5kZXIuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
   | [...che/dolphinscheduler/common/utils/HadoopUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0hhZG9vcFV0aWxzLmphdmE=) | `24.43% <0%> (-0.29%)` | :arrow_down: |
   | [...he/dolphinscheduler/common/model/DateInterval.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL21vZGVsL0RhdGVJbnRlcnZhbC5qYXZh) | `14.28% <16.66%> (-5.72%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=footer). Last update [1f7db8f...5f4c87c](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1721: Fix bug: NullPointerException etc.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1721: Fix bug: NullPointerException etc.
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1721#issuecomment-570918714
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=h1) Report
   > Merging [#1721](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/b9ac6d66f1d5e0a2d170278630eac267bb473be1?src=pr&el=desc) will **decrease** coverage by `0.02%`.
   > The diff coverage is `4.16%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##              dev    #1721      +/-   ##
   ==========================================
   - Coverage   21.02%   20.99%   -0.03%     
   ==========================================
     Files         292      292              
     Lines       14069    14082      +13     
     Branches     2321     2325       +4     
   ==========================================
   - Hits         2958     2957       -1     
   - Misses      10775    10788      +13     
   - Partials      336      337       +1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...g/apache/dolphinscheduler/dao/utils/DagHelper.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3V0aWxzL0RhZ0hlbHBlci5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
   | [.../dolphinscheduler/api/service/ExecutorService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRXhlY3V0b3JTZXJ2aWNlLmphdmE=) | `0.46% <0%> (-0.01%)` | :arrow_down: |
   | [...che/dolphinscheduler/alert/runner/AlertSender.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9ydW5uZXIvQWxlcnRTZW5kZXIuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
   | [...che/dolphinscheduler/common/utils/HadoopUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0hhZG9vcFV0aWxzLmphdmE=) | `24.43% <0%> (-0.29%)` | :arrow_down: |
   | [...he/dolphinscheduler/common/model/DateInterval.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL21vZGVsL0RhdGVJbnRlcnZhbC5qYXZh) | `14.28% <16.66%> (-5.72%)` | :arrow_down: |
   | [...cheduler/api/service/ProcessDefinitionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0RlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `29.17% <0%> (-0.16%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=footer). Last update [b9ac6d6...d67039c](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1721: Fix bug: NullPointerException etc.

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #1721: Fix bug: NullPointerException etc.
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1721#issuecomment-572604249
 
 
   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1721&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1721&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1721&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1721&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1721&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1721&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1721&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1721&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1721&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1721&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1721&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='7.7%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1721&metric=new_coverage&view=list) [7.7% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1721&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1721&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1721&metric=new_duplicated_lines_density&view=list)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on issue #1721: Fix bug: NullPointerException etc.

Posted by GitBox <gi...@apache.org>.
qiaozhanwei commented on issue #1721: Fix bug: NullPointerException etc.
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1721#issuecomment-572353852
 
 
   please resolve conflicts

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1721: Fix bug: NullPointerException etc.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1721: Fix bug: NullPointerException etc.
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1721#issuecomment-570918714
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=h1) Report
   > Merging [#1721](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/5f4c87c7c5011cc87f63e8e9dae1e80e0519b890?src=pr&el=desc) will **increase** coverage by `3.52%`.
   > The diff coverage is `34.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##              dev    #1721      +/-   ##
   ==========================================
   + Coverage   17.47%   20.99%   +3.52%     
   ==========================================
     Files         285      292       +7     
     Lines       13926    14082     +156     
     Branches     2279     2325      +46     
   ==========================================
   + Hits         2433     2956     +523     
   + Misses      11219    10790     -429     
   - Partials      274      336      +62
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...hinscheduler/api/controller/ProjectController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvUHJvamVjdENvbnRyb2xsZXIuamF2YQ==) | `1.75% <ø> (+1.75%)` | :arrow_up: |
   | [...uler/server/worker/log/SensitiveDataConverter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9sb2cvU2Vuc2l0aXZlRGF0YUNvbnZlcnRlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...che/dolphinscheduler/dao/entity/ResourcesUser.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9SZXNvdXJjZXNVc2VyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
   | [...pache/dolphinscheduler/dao/entity/ProjectUser.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Qcm9qZWN0VXNlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [.../org/apache/dolphinscheduler/dao/entity/Alert.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9BbGVydC5qYXZh) | `8.69% <ø> (+0.69%)` | :arrow_up: |
   | [...g/apache/dolphinscheduler/dao/entity/Resource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9SZXNvdXJjZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...rg/apache/dolphinscheduler/dao/entity/Project.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Qcm9qZWN0LmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
   | [...rg/apache/dolphinscheduler/dao/entity/UdfFunc.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9VZGZGdW5jLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
   | [...rg/apache/dolphinscheduler/dao/entity/Command.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Db21tYW5kLmphdmE=) | `10.29% <ø> (ø)` | :arrow_up: |
   | [...rg/apache/dolphinscheduler/dao/entity/UDFUser.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9VREZVc2VyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
   | ... and [89 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=footer). Last update [5f4c87c...d67039c](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Jave-Chen commented on a change in pull request #1721: Fix bug: NullPointerException etc.

Posted by GitBox <gi...@apache.org>.
Jave-Chen commented on a change in pull request #1721: Fix bug: NullPointerException etc.
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1721#discussion_r364040852
 
 

 ##########
 File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/model/DateInterval.java
 ##########
 @@ -35,13 +35,18 @@ public DateInterval(Date beginTime, Date endTime){
 
     @Override
     public boolean equals(Object obj) {
-        try{
-            DateInterval dateInterval = (DateInterval) obj;
-            return startTime.equals(dateInterval.getStartTime()) &&
-                    endTime.equals(dateInterval.getEndTime());
-        }catch (Exception e){
+        if (obj != null) {
 
 Review comment:
   check whether obj is null

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Jave-Chen commented on issue #1721: Fix bug: NullPointerException etc.

Posted by GitBox <gi...@apache.org>.
Jave-Chen commented on issue #1721: Fix bug: NullPointerException etc.
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1721#issuecomment-572605380
 
 
   > please resolve conflicts
   
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in pull request #1721: Fix bug: NullPointerException etc.

Posted by GitBox <gi...@apache.org>.
Technoboy- commented on a change in pull request #1721: Fix bug: NullPointerException etc.
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1721#discussion_r363324325
 
 

 ##########
 File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/model/DateInterval.java
 ##########
 @@ -35,13 +35,18 @@ public DateInterval(Date beginTime, Date endTime){
 
     @Override
     public boolean equals(Object obj) {
-        try{
-            DateInterval dateInterval = (DateInterval) obj;
-            return startTime.equals(dateInterval.getStartTime()) &&
-                    endTime.equals(dateInterval.getEndTime());
-        }catch (Exception e){
+        if (obj != null) {
 
 Review comment:
   why use try/catch surround equals method?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] dailidong merged pull request #1721: Fix bug: NullPointerException etc.

Posted by GitBox <gi...@apache.org>.
dailidong merged pull request #1721: Fix bug: NullPointerException etc.
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1721
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1721: Fix bug: NullPointerException etc.

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1721: Fix bug: NullPointerException etc.
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1721#issuecomment-570918714
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=h1) Report
   > Merging [#1721](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/1f7db8f7975d2d01048eaaeae98d4425417abbae?src=pr&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `3.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##              dev    #1721      +/-   ##
   ==========================================
   - Coverage   17.48%   17.47%   -0.02%     
   ==========================================
     Files         285      285              
     Lines       13912    13926      +14     
     Branches     2274     2279       +5     
   ==========================================
     Hits         2433     2433              
   - Misses      11206    11219      +13     
   - Partials      273      274       +1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...g/apache/dolphinscheduler/dao/utils/DagHelper.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3V0aWxzL0RhZ0hlbHBlci5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
   | [.../dolphinscheduler/api/service/ExecutorService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRXhlY3V0b3JTZXJ2aWNlLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
   | [...che/dolphinscheduler/alert/runner/AlertSender.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9ydW5uZXIvQWxlcnRTZW5kZXIuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
   | [...che/dolphinscheduler/common/utils/HadoopUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0hhZG9vcFV0aWxzLmphdmE=) | `24.43% <0%> (-0.29%)` | :arrow_down: |
   | [...he/dolphinscheduler/common/model/DateInterval.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL21vZGVsL0RhdGVJbnRlcnZhbC5qYXZh) | `14.28% <16.66%> (-5.72%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=footer). Last update [1f7db8f...5c1bb39](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1721?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services