You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/09/25 01:06:26 UTC
[GitHub] [spark] panbingkun opened a new pull request, #43076: [SPARK-45293][INFRA] Install Java 17 for docker
panbingkun opened a new pull request, #43076:
URL: https://github.com/apache/spark/pull/43076
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
Manually test:
1.
2.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang closed pull request #43076: [SPARK-45276][INFRA] Replace Java 8 and Java 11 installed in the Dockerfile with Java
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang closed pull request #43076: [SPARK-45276][INFRA] Replace Java 8 and Java 11 installed in the Dockerfile with Java
URL: https://github.com/apache/spark/pull/43076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #43076: [SPARK-45276][INFRA] Replace Java 8 and Java 11 installed in the Dockerfile with Java
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43076:
URL: https://github.com/apache/spark/pull/43076#issuecomment-1737197585
is this one ready to go?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #43076: [SPARK-45276][INFRA] Replace Java 8 and Java 11 installed in the Dockerfile with Java
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #43076:
URL: https://github.com/apache/spark/pull/43076#discussion_r1335298085
##########
dev/create-release/spark-rm/Dockerfile:
##########
@@ -61,9 +61,9 @@ RUN apt-get clean && apt-get update && $APT_INSTALL gnupg ca-certificates && \
apt-get update && \
Review Comment:
Okay, let me fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #43076: [SPARK-45276][INFRA] Replace Java 8 and Java 11 installed in the Dockerfile with Java
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #43076:
URL: https://github.com/apache/spark/pull/43076#discussion_r1335295623
##########
dev/create-release/spark-rm/Dockerfile:
##########
@@ -61,9 +61,9 @@ RUN apt-get clean && apt-get update && $APT_INSTALL gnupg ca-certificates && \
apt-get update && \
Review Comment:
Since you're here, can you also fix the comments at `dev/create-release/do-release-docker.sh`:
```
-j [path] : path to local JDK installation to use for building. By default the script will
use openjdk8 installed in the docker image.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #43076: [SPARK-45276][INFRA] Replace Java 8 and Java 11 installed in the Dockerfile with Java
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43076:
URL: https://github.com/apache/spark/pull/43076#issuecomment-1740183575
Merged into master for Spark 4.0. Thanks @panbingkun @HyukjinKwon and @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #43076: [SPARK-45276][INFRA] Replace Java 8 and Java 11 installed in the Dockerfile with Java
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #43076:
URL: https://github.com/apache/spark/pull/43076#issuecomment-1732759125
cc @LuciferYang @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #43076: [SPARK-45276][INFRA] Replace Java 8 and Java 11 installed in the Dockerfile with Java
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #43076:
URL: https://github.com/apache/spark/pull/43076#discussion_r1338457178
##########
dev/create-release/spark-rm/Dockerfile:
##########
@@ -61,9 +61,9 @@ RUN apt-get clean && apt-get update && $APT_INSTALL gnupg ca-certificates && \
apt-get update && \
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #43076: [SPARK-45276][INFRA] Replace Java 8 and Java 11 installed in the Dockerfile with Java
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #43076:
URL: https://github.com/apache/spark/pull/43076#issuecomment-1737205033
> is this one ready to go?
Yes, it has been completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #43076: [SPARK-45276][INFRA] Replace Java 8 and Java 11 installed in the Dockerfile with Java
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #43076:
URL: https://github.com/apache/spark/pull/43076#discussion_r1339392029
##########
binder/apt.txt:
##########
@@ -1,2 +1,2 @@
-openjdk-8-jre
+openjdk-17-jre
Review Comment:
Hm, this was actually fixed by https://github.com/apache/spark/commit/bb0d287114fbebf0c5457cee066c5080735a48a4 :-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org