You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zuston (via GitHub)" <gi...@apache.org> on 2025/09/18 03:15:36 UTC
[PR] [#2618] fix(spark): Invalid reassign status show in spark UI tab [uniffle]
zuston opened a new pull request, #2620:
URL: https://github.com/apache/uniffle/pull/2620
### What changes were proposed in this pull request?
Fix the invalid reassign status show in spark UI tab
### Why are the changes needed?
In the original design, the reassign info event is sent in the final stop method. However, because the post operation runs asynchronously, the listener may not receive the event before the JVM shuts down, so the event is effectively dropped.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Internal spark job test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2618] fix(spark): Invalid reassign status show in spark UI tab [uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #2620:
URL: https://github.com/apache/uniffle/pull/2620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2618] fix(spark): Invalid reassign status show in spark UI tab [uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2620:
URL: https://github.com/apache/uniffle/pull/2620#issuecomment-3305342388
## Test Results
3 120 files ±0 3 120 suites ±0 6h 49m 32s ⏱️ - 1m 49s
1 201 tests ±0 1 200 ✅ ±0 1 💤 ±0 0 ❌ ±0
15 211 runs ±0 15 196 ✅ ±0 15 💤 ±0 0 ❌ ±0
Results for commit 09a77243. ± Comparison against base commit e0a49b93.
[test-results]:data:application/gzip;base64,H4sIANuEy2gC/03MTQ6DIBCG4asY1l3A8DPSyzQEMSFVaRBWpncvWlSW3zOTdyOjn9xKnh1nQB8dWbNP7R5yNMmHpQgIiVCo3NP+UR7YOV9rtvZv9La3/+x2wWj8VOD+cDGGWCXm5ahKYKzOqyqZVpfVqjyhqR67jdowzz6VQag2iCC46HuFErAXzAxolRu1c5bLQXGgKBT5/gCX/kedFAEAAA==
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2618] fix(spark): Invalid reassign status show in spark UI tab [uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #2620:
URL: https://github.com/apache/uniffle/pull/2620#discussion_r2357419120
##########
client-spark/common/src/main/java/org/apache/uniffle/shuffle/manager/RssShuffleManagerBase.java:
##########
@@ -1148,15 +1148,24 @@ public MutableShuffleHandleInfo reassignOnBlockSendFailure(
System.currentTimeMillis() - startTime,
partitionSplit,
reassignResult);
- if (partitionSplit) {
- this.reassignTriggeredOnPartitionSplit.set(true);
- } else {
- this.reassignTriggeredOnBlockSendFailure.set(true);
- }
+ postReassignTriggeredEvent(
+ partitionSplit ? reassignTriggeredOnPartitionSplit : reassignTriggeredOnBlockSendFailure);
return internalHandle;
}
}
+ /** This method will check the historical state to avoid posting duplicate events */
+ private void postReassignTriggeredEvent(AtomicBoolean tag) {
Review Comment:
Could u give a better name for `tag`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org