You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/07/03 21:29:23 UTC
Re: Review Request 66842: Added per-framework metrics for offer filter
durations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66842/
-----------------------------------------------------------
(Updated July 3, 2018, 9:29 p.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Summary (updated)
-----------------
Added per-framework metrics for offer filter durations.
Repository: mesos
Description
-------
These per-framework metrics provide counts of the numbers
of filters set by each framework, bucketed according to
the 'refuse_seconds' duration.
Diffs (updated)
-----
src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/66842/diff/7/
Changes: https://reviews.apache.org/r/66842/diff/6-7/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 66842: Added per-framework metrics for offer filter
durations.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66842/#review205828
-----------------------------------------------------------
src/master/metrics.cpp
Lines 606-612 (patched)
<https://reviews.apache.org/r/66842/#comment288734>
Let's use singular names for these metrics.
src/master/metrics.cpp
Lines 625 (patched)
<https://reviews.apache.org/r/66842/#comment288733>
I'd get rid of this empty line.
src/master/metrics.cpp
Lines 887 (patched)
<https://reviews.apache.org/r/66842/#comment288735>
I'd use `duration` here and then `bucketDuration` in the foreach loop.
- Gastón Kleiman
On July 6, 2018, 2:50 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66842/
> -----------------------------------------------------------
>
> (Updated July 6, 2018, 2:50 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These per-framework metrics provide counts of the numbers
> of filters set by each framework, bucketed according to
> the 'refuse_seconds' duration.
>
>
> Diffs
> -----
>
> src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/66842/diff/9/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 66842: Added per-framework metrics for offer filter
durations.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66842/
-----------------------------------------------------------
(Updated July 9, 2018, 3:56 p.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Repository: mesos
Description
-------
These per-framework metrics provide counts of the numbers
of filters set by each framework, bucketed according to
the 'refuse_seconds' duration.
Diffs (updated)
-----
src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/66842/diff/10/
Changes: https://reviews.apache.org/r/66842/diff/9-10/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 66842: Added per-framework metrics for offer filter
durations.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66842/
-----------------------------------------------------------
(Updated July 6, 2018, 9:50 p.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Repository: mesos
Description
-------
These per-framework metrics provide counts of the numbers
of filters set by each framework, bucketed according to
the 'refuse_seconds' duration.
Diffs (updated)
-----
src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/66842/diff/9/
Changes: https://reviews.apache.org/r/66842/diff/8-9/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 66842: Added per-framework metrics for offer filter
durations.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66842/
-----------------------------------------------------------
(Updated July 6, 2018, 8:52 p.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Repository: mesos
Description
-------
These per-framework metrics provide counts of the numbers
of filters set by each framework, bucketed according to
the 'refuse_seconds' duration.
Diffs (updated)
-----
src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/66842/diff/8/
Changes: https://reviews.apache.org/r/66842/diff/7-8/
Testing
-------
Thanks,
Greg Mann