You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "brandboat (via GitHub)" <gi...@apache.org> on 2024/04/28 11:07:57 UTC
[PR] KAFKA-16627: Remove ClusterConfig parameter in BeforeEach and AfterEach [kafka]
brandboat opened a new pull request, #15824:
URL: https://github.com/apache/kafka/pull/15824
related to [KAFKA-16627](https://issues.apache.org/jira/browse/KAFKA-16627)
In the past we modify configs like server broker properties by modifying the ClusterConfig reference passed to BeforeEach and AfterEach based on the requirements of the tests.
While after [KAFKA-16560](https://issues.apache.org/jira/browse/KAFKA-16560), the ClusterConfig become immutable, modify the ClusterConfig reference no longer reflects any changes to the test cluster. Then pass ClusterConfig to BeforeEach and AfterEach become redundant.
This pr directly remove the behavior that pass `ClusterConfig` to all test methods and before/after each method.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16627: Remove ClusterConfig parameter in BeforeEach and AfterEach [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #15824:
URL: https://github.com/apache/kafka/pull/15824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org