[jira] [Work logged] (ARTEMIS-3554) Prepared Transaction with Invalid Data may prevent a server start

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-3554?focusedWorklogId=676826&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-676826 ]

ASF GitHub Bot logged work on ARTEMIS-3554:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Nov/21 00:57
            Start Date: 05/Nov/21 00:57
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on a change in pull request #3838:
URL: https://github.com/apache/activemq-artemis/pull/3838#discussion_r743323587



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
##########
@@ -1236,6 +1238,22 @@ public JournalLoadInformation loadMessageJournal(final PostOffice postOffice,
       }
    }
 
+   private void failedToPrepareException(PreparedTransactionInfo txInfo, Throwable e) {
+      XidEncoding encodingXid = null;
+      try {
+          encodingXid = new XidEncoding(txInfo.getExtraData());
+      } catch (Throwable ignored) {
+      }
+
+      ActiveMQServerLogger.LOGGER.warn("Failed to load prepared TX " + encodingXid.xid + ", Prepared Transaction will be rolled back", e);

Review comment:
       I will make this as a Logger with a code. Hence the PR is a draft still.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 676826)
    Time Spent: 20m  (was: 10m)

> Prepared Transaction with Invalid Data may prevent a server start
> -----------------------------------------------------------------
>
>                 Key: ARTEMIS-3554
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3554
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Clebert Suconic
>            Assignee: Clebert Suconic
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Prepare a transaction with an ACK on page
> Stop the server
> remove the paging files
> The server will not start
> The transaction should be logged with a warn, rolled back and the server start normally.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)