You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Mark Struberg (JIRA)" <de...@myfaces.apache.org> on 2011/08/30 16:05:38 UTC

[jira] [Created] (EXTCDI-220) ViewAccessScoped beans are not properly destroyed

ViewAccessScoped beans are not properly destroyed
-------------------------------------------------

                 Key: EXTCDI-220
                 URL: https://issues.apache.org/jira/browse/EXTCDI-220
             Project: MyFaces CODI
          Issue Type: Bug
          Components: Core
    Affects Versions: 1.0.1
            Reporter: Mark Struberg
            Assignee: Mark Struberg
            Priority: Critical


currently we don't invoke Contextual#destroy() while removing ViewAccessScoped beans from the context on expiration.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (EXTCDI-220) @PreDestroy not called when closing sub-groups

Posted by "Gerhard Petracek (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/EXTCDI-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093968#comment-13093968 ] 

Gerhard Petracek commented on EXTCDI-220:
-----------------------------------------

refixed in r1163312

> @PreDestroy not called when closing sub-groups
> ----------------------------------------------
>
>                 Key: EXTCDI-220
>                 URL: https://issues.apache.org/jira/browse/EXTCDI-220
>             Project: MyFaces CODI
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.1
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>            Priority: Minor
>             Fix For: 1.0.2
>
>
> currently we don't invoke Contextual#destroy() while removing sub-groups. grouped conversations aren't affected - only subgroups.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Reopened] (EXTCDI-220) ViewAccessScoped beans are not properly destroyed

Posted by "Mark Struberg (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/EXTCDI-220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Struberg reopened EXTCDI-220:
----------------------------------


JsfWindowContext#closeSubGroups and a few others call to EditableConversation#removeBeanEntry() 

> ViewAccessScoped beans are not properly destroyed
> -------------------------------------------------
>
>                 Key: EXTCDI-220
>                 URL: https://issues.apache.org/jira/browse/EXTCDI-220
>             Project: MyFaces CODI
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.1
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>            Priority: Minor
>
> currently we don't invoke Contextual#destroy() while removing ViewAccessScoped beans from the context on expiration.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (EXTCDI-220) ViewAccessScoped beans are not properly destroyed

Posted by "Mark Struberg (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/EXTCDI-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093927#comment-13093927 ] 

Mark Struberg commented on EXTCDI-220:
--------------------------------------

yes true, it's not a general ViewAccessScoped problem but rather a subgroup one. will fix the title of the issue

> ViewAccessScoped beans are not properly destroyed
> -------------------------------------------------
>
>                 Key: EXTCDI-220
>                 URL: https://issues.apache.org/jira/browse/EXTCDI-220
>             Project: MyFaces CODI
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.1
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>            Priority: Minor
>
> currently we don't invoke Contextual#destroy() while removing ViewAccessScoped beans from the context on expiration.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (EXTCDI-220) @PreDestroy not called when closing sub-groups

Posted by "Mark Struberg (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/EXTCDI-220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Struberg resolved EXTCDI-220.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.0.2

fixed in r1163305.

> @PreDestroy not called when closing sub-groups
> ----------------------------------------------
>
>                 Key: EXTCDI-220
>                 URL: https://issues.apache.org/jira/browse/EXTCDI-220
>             Project: MyFaces CODI
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.1
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>            Priority: Minor
>             Fix For: 1.0.2
>
>
> currently we don't invoke Contextual#destroy() while removing sub-groups. grouped conversations aren't affected - only subgroups.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (EXTCDI-220) ViewAccessScoped beans are not properly destroyed

Posted by "Gerhard Petracek (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/EXTCDI-220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gerhard Petracek resolved EXTCDI-220.
-------------------------------------

    Resolution: Invalid

BeanStorage#resetStorage destroys it properly via beanHolder.getBean().destroy(...)

> ViewAccessScoped beans are not properly destroyed
> -------------------------------------------------
>
>                 Key: EXTCDI-220
>                 URL: https://issues.apache.org/jira/browse/EXTCDI-220
>             Project: MyFaces CODI
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.1
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>            Priority: Critical
>
> currently we don't invoke Contextual#destroy() while removing ViewAccessScoped beans from the context on expiration.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (EXTCDI-220) ViewAccessScoped beans are not properly destroyed

Posted by "Gerhard Petracek (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/EXTCDI-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093926#comment-13093926 ] 

Gerhard Petracek commented on EXTCDI-220:
-----------------------------------------

ok - but it isn't related to the ViewAccessScoped.
affected is EditableConversation#removeBeanEntry which is new and only used for grouped conversations and there only for subgroups

> ViewAccessScoped beans are not properly destroyed
> -------------------------------------------------
>
>                 Key: EXTCDI-220
>                 URL: https://issues.apache.org/jira/browse/EXTCDI-220
>             Project: MyFaces CODI
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.1
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>            Priority: Minor
>
> currently we don't invoke Contextual#destroy() while removing ViewAccessScoped beans from the context on expiration.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (EXTCDI-220) @PreDestroy not called when closing sub-groups

Posted by "Mark Struberg (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/EXTCDI-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093996#comment-13093996 ] 

Mark Struberg commented on EXTCDI-220:
--------------------------------------

Imo the last commit should get rollbacked. Removal from teh BeanStorage doesn't automatically mean the object wont be used anymore.
A use case: bean history to get rid of the browser back button problem. The Contextual#destroy must only be called if the instance get dropped from the history. But the BeanStorage has not sufficient knowledge about this!

> @PreDestroy not called when closing sub-groups
> ----------------------------------------------
>
>                 Key: EXTCDI-220
>                 URL: https://issues.apache.org/jira/browse/EXTCDI-220
>             Project: MyFaces CODI
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.1
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>            Priority: Minor
>             Fix For: 1.0.2
>
>
> currently we don't invoke Contextual#destroy() while removing sub-groups. grouped conversations aren't affected - only subgroups.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira