You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2023/01/16 00:11:03 UTC
[GitHub] [iceberg] rdblue opened a new pull request, #6599: Core: Add information_schema.namespaces table
rdblue opened a new pull request, #6599:
URL: https://github.com/apache/iceberg/pull/6599
This is based on #6357 and will be rebased once that PR is merged.
This adds `information_schema.namespaces` and base classes for creating new `information_schema` tables. Namespace filtering is implemented to avoid too many queries against catalogs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #6599: Core: Add information_schema.namespaces table
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on code in PR #6599:
URL: https://github.com/apache/iceberg/pull/6599#discussion_r1252392805
##########
api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java:
##########
@@ -82,6 +83,24 @@ public static String toSanitizedString(Expression expr) {
return ExpressionVisitors.visit(expr, new StringSanitizer());
}
+ /**
+ * Extracts an expression that references only the given column IDs from the given expression.
+ *
+ * <p>The result is inclusive. If a row would match the original filter, it must match the result
+ * filter.
+ *
+ * @param expression a filter Expression
+ * @param schema a Schema
+ * @param caseSensitive whether binding is case sensitive
+ * @param ids field IDs used to match predicates to extract from the expression
+ * @return an Expression that selects at least the same rows as the original using only the IDs
+ */
+ public static Expression extractByIdInclusive(
Review Comment:
Looks like the tests were missing. I'll add those when I clean this up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #6599: Core: Add information_schema.namespaces table
Posted by "aokolnychyi (via GitHub)" <gi...@apache.org>.
aokolnychyi commented on PR #6599:
URL: https://github.com/apache/iceberg/pull/6599#issuecomment-1428952593
@rdblue, could you rebase? I can review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #6599: Core: Add information_schema.namespaces table
Posted by "aokolnychyi (via GitHub)" <gi...@apache.org>.
aokolnychyi commented on code in PR #6599:
URL: https://github.com/apache/iceberg/pull/6599#discussion_r1110361463
##########
api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java:
##########
@@ -82,6 +83,24 @@ public static String toSanitizedString(Expression expr) {
return ExpressionVisitors.visit(expr, new StringSanitizer());
}
+ /**
+ * Extracts an expression that references only the given column IDs from the given expression.
+ *
+ * <p>The result is inclusive. If a row would match the original filter, it must match the result
+ * filter.
+ *
+ * @param expression a filter Expression
+ * @param schema a Schema
+ * @param caseSensitive whether binding is case sensitive
+ * @param ids field IDs used to match predicates to extract from the expression
+ * @return an Expression that selects at least the same rows as the original using only the IDs
+ */
+ public static Expression extractByIdInclusive(
Review Comment:
This has been already merged in #6716.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org