You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/06/04 18:29:46 UTC
[Impala-ASF-CR] Collect hs err pid*.log files in logs/
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10594
Change subject: Collect hs_err_pid*.log files in logs/
......................................................................
Collect hs_err_pid*.log files in logs/
These JVM error dumps are often useful for debugging job failures. We
should put them into the logs/ directory so they can be collected
along with other logs.
This was motivated by IMPALA-7069.
Testing:
Induced a segfault by changing the code, checked that the file ended up
in the logs/ subdirectory.
Change-Id: I753f6acb63cec600432675cfb6e5dd1e1427b5ae
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/10594/1
--
To view, visit http://gerrit.cloudera.org:8080/10594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I753f6acb63cec600432675cfb6e5dd1e1427b5ae
Gerrit-Change-Number: 10594
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Collect hs err pid*.log files in logs/
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10594 )
Change subject: Collect hs_err_pid*.log files in logs/
......................................................................
Collect hs_err_pid*.log files in logs/
These JVM error dumps are often useful for debugging job failures. We
should put them into the logs/ directory so they can be collected
along with other logs.
This was motivated by IMPALA-7069.
Testing:
Induced a segfault by changing the code, checked that the file ended up
in the logs/ subdirectory.
Change-Id: I753f6acb63cec600432675cfb6e5dd1e1427b5ae
Reviewed-on: http://gerrit.cloudera.org:8080/10594
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Lars Volker: Looks good to me, but someone else must approve
Impala Public Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I753f6acb63cec600432675cfb6e5dd1e1427b5ae
Gerrit-Change-Number: 10594
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Collect hs err pid*.log files in logs/
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10594 )
Change subject: Collect hs_err_pid*.log files in logs/
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2586/
--
To view, visit http://gerrit.cloudera.org:8080/10594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I753f6acb63cec600432675cfb6e5dd1e1427b5ae
Gerrit-Change-Number: 10594
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Jun 2018 21:11:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Collect hs err pid*.log files in logs/
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10594 )
Change subject: Collect hs_err_pid*.log files in logs/
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I753f6acb63cec600432675cfb6e5dd1e1427b5ae
Gerrit-Change-Number: 10594
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jun 2018 06:10:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Collect hs err pid*.log files in logs/
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10594 )
Change subject: Collect hs_err_pid*.log files in logs/
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/10594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I753f6acb63cec600432675cfb6e5dd1e1427b5ae
Gerrit-Change-Number: 10594
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Jun 2018 18:51:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Collect hs err pid*.log files in logs/
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10594 )
Change subject: Collect hs_err_pid*.log files in logs/
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I753f6acb63cec600432675cfb6e5dd1e1427b5ae
Gerrit-Change-Number: 10594
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jun 2018 03:17:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Collect hs err pid*.log files in logs/
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10594 )
Change subject: Collect hs_err_pid*.log files in logs/
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2590/
--
To view, visit http://gerrit.cloudera.org:8080/10594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I753f6acb63cec600432675cfb6e5dd1e1427b5ae
Gerrit-Change-Number: 10594
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Jun 2018 23:54:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Collect hs err pid*.log files in logs/
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10594 )
Change subject: Collect hs_err_pid*.log files in logs/
......................................................................
Patch Set 1:
Hit https://issues.apache.org/jira/browse/IMPALA-7120
--
To view, visit http://gerrit.cloudera.org:8080/10594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I753f6acb63cec600432675cfb6e5dd1e1427b5ae
Gerrit-Change-Number: 10594
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Jun 2018 23:57:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Collect hs err pid*.log files in logs/
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10594 )
Change subject: Collect hs_err_pid*.log files in logs/
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2586/
--
To view, visit http://gerrit.cloudera.org:8080/10594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I753f6acb63cec600432675cfb6e5dd1e1427b5ae
Gerrit-Change-Number: 10594
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Jun 2018 22:56:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Collect hs err pid*.log files in logs/
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10594 )
Change subject: Collect hs_err_pid*.log files in logs/
......................................................................
Patch Set 1:
Seems ok to promote to a +2
--
To view, visit http://gerrit.cloudera.org:8080/10594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I753f6acb63cec600432675cfb6e5dd1e1427b5ae
Gerrit-Change-Number: 10594
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jun 2018 06:10:18 +0000
Gerrit-HasComments: No