You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/21 15:20:18 UTC
[GitHub] [pulsar] lhotari opened a new pull request #13435: Fix invalid setting of enabled ciphers to fix warning from BoringSSL
lhotari opened a new pull request #13435:
URL: https://github.com/apache/pulsar/pull/13435
### Motivation
When running pulsar-admin and connecting to a broker with TLS, the first two lines of output in standard output are warnings from Netty / BoringSSL:
```
17:15:47.460 [main] INFO io.netty.handler.ssl.ReferenceCountedOpenSslContext - BoringSSL doesn't allow to enable or disable TLSv1.3 ciphers explicitly. Provided TLSv1.3 ciphers: 'TLS_AES_128_GCM_SHA256:TLS_AES_256_GCM_SHA384:TLS_AES_128_GCM_SHA256:TLS_AES_256_GCM_SHA384', default TLSv1.3 ciphers that will be used: 'TLS_AES_128_GCM_SHA256:TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256'.
17:15:47.814 [main] INFO io.netty.handler.ssl.ReferenceCountedOpenSslContext - BoringSSL doesn't allow to enable or disable TLSv1.3 ciphers explicitly. Provided TLSv1.3 ciphers: 'TLS_AES_128_GCM_SHA256:TLS_AES_256_GCM_SHA384:TLS_AES_128_GCM_SHA256:TLS_AES_256_GCM_SHA384', default TLSv1.3 ciphers that will be used: 'TLS_AES_128_GCM_SHA256:TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256'.
```
This is annoying since it garbles the output.
### Modifications
Don't call `sslEngine.setEnabledCipherSuites(sslEngine.getSupportedCipherSuites())` at all since it is useless. That's what causes the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #13435: Fix invalid setting of enabled ciphers to fix warning from BoringSSL
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #13435:
URL: https://github.com/apache/pulsar/pull/13435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari closed pull request #13435: Fix invalid setting of enabled ciphers to fix warning from BoringSSL
Posted by GitBox <gi...@apache.org>.
lhotari closed pull request #13435:
URL: https://github.com/apache/pulsar/pull/13435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #13435: Fix invalid setting of enabled ciphers to fix warning from BoringSSL
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #13435:
URL: https://github.com/apache/pulsar/pull/13435#issuecomment-998877072
When cherry-picking, #13322 must be cherry-picked before this change. /cc @nicoloboschi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari closed pull request #13435: Fix invalid setting of enabled ciphers to fix warning from BoringSSL
Posted by GitBox <gi...@apache.org>.
lhotari closed pull request #13435:
URL: https://github.com/apache/pulsar/pull/13435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org