[GitHub] [tvm] FrozenGene commented on a change in pull request #7877: Async measurer API for auto-scheduler scripts

[GitBox <gi...@apache.org>]

FrozenGene commented on a change in pull request #7877:
URL: https://github.com/apache/tvm/pull/7877#discussion_r615512179



##########
File path: include/tvm/auto_scheduler/measure.h
##########
@@ -340,9 +351,14 @@ class LocalBuilderNode : public ProgramBuilderNode {
  public:
   /*! \brief Build function. */
   String build_func;
+  /*! \brief Functor with python implementation of submit method. */
+  PackedFunc submit_func;

Review comment:
       Could this work well on the remote or this only happens on the host side?

##########
File path: include/tvm/auto_scheduler/measure.h
##########
@@ -444,10 +469,9 @@ class RPCRunner : public ProgramRunner {
    * \param cooldown_interval The cool down interval between two measurements.
    * \param enable_cpu_cache_flush Whether to flush cache on CPU between repeated measurements.
    */
-  RPCRunner(const String& key, const String& host, int port, int priority, int n_parallel,
-            int timeout, int number, int repeat, int min_repeat_ms, double cooldown_interval,
-            bool enable_cpu_cache_flush);
-
+  RPCRunner(PackedFunc submit_func, const String& key, const String& host, int port, int priority,

Review comment:
       As previous comment, I doubt `PackedFunc` can not work well on the remote. Like `cache flush`, we use `string` to pass. See: https://github.com/apache/tvm/blob/main/python/tvm/auto_scheduler/measure.py#L849
   
   Let us add test case to cover.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org