[GitHub] [spark] cloud-fan commented on a change in pull request #33624: [SPARK-35881][SQL][FOLLOWUP] Add a boolean flag in AdaptiveSparkPlanExec to ask for columnar output

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #33624:
URL: https://github.com/apache/spark/pull/33624#discussion_r681984379



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/Columnar.scala
##########
@@ -521,7 +499,8 @@ case class RowToColumnarExec(child: SparkPlan) extends RowToColumnarTransition {
  * to/from columnar formatted data.
  */
 case class ApplyColumnarRulesAndInsertTransitions(
-    columnarRules: Seq[ColumnarRule])
+    columnarRules: Seq[ColumnarRule],
+    outputColumnar: Boolean = false)

Review comment:
       This is the new change. Previously we always assume that the final plan should output row data and add `ColumnarToRowExec` if the plan is columnar. Now the caller side can specify if the final plan should output columnar format or not.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org