You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by st...@apache.org on 2018/02/15 19:39:11 UTC

tomee git commit: fix broken unit test

Repository: tomee
Updated Branches:
  refs/heads/fb_tomee8 d06eadef2 -> 0dcf9d270


fix broken unit test

"true" is not a valid value for tomcat since tc5.
Allowed values according to the tomcat docu are 'off', 'on' and 'force'
https://tomcat.apache.org/tomcat-9.0-doc/config/http.html


Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/0dcf9d27
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/0dcf9d27
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/0dcf9d27

Branch: refs/heads/fb_tomee8
Commit: 0dcf9d2709aaa46b145473021f4b27d192b7e0ff
Parents: d06eade
Author: Mark Struberg <st...@apache.org>
Authored: Thu Feb 15 20:35:45 2018 +0100
Committer: Mark Struberg <st...@apache.org>
Committed: Thu Feb 15 20:35:45 2018 +0100

----------------------------------------------------------------------
 .../test/java/org/apache/tomee/embedded/ConnectorConfigTest.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tomee/blob/0dcf9d27/tomee/tomee-embedded/src/test/java/org/apache/tomee/embedded/ConnectorConfigTest.java
----------------------------------------------------------------------
diff --git a/tomee/tomee-embedded/src/test/java/org/apache/tomee/embedded/ConnectorConfigTest.java b/tomee/tomee-embedded/src/test/java/org/apache/tomee/embedded/ConnectorConfigTest.java
index 6b2dfb9..3a38107 100644
--- a/tomee/tomee-embedded/src/test/java/org/apache/tomee/embedded/ConnectorConfigTest.java
+++ b/tomee/tomee-embedded/src/test/java/org/apache/tomee/embedded/ConnectorConfigTest.java
@@ -34,7 +34,7 @@ public class ConnectorConfigTest {
         try {
             new Container(new Configuration()
                     .property("connector.xpoweredBy", "true")
-                    .property("connector.attributes.compression", "true")
+                    .property("connector.attributes.compression", "on")
                     .property("connector.attributes.maxHeaderCount", "2016")) {
 
                 @Override
@@ -52,7 +52,7 @@ public class ConnectorConfigTest {
             assertNotNull(c);
             assertTrue(c.getXpoweredBy());
             assertEquals(2016, AbstractHttp11Protocol.class.cast(c.getProtocolHandler()).getMaxHeaderCount());
-            assertEquals("true", AbstractHttp11Protocol.class.cast(c.getProtocolHandler()).getCompression());
+            assertEquals("on", AbstractHttp11Protocol.class.cast(c.getProtocolHandler()).getCompression());
         }
     }
 }