You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2018/01/22 02:06:41 UTC

[GitHub] spark pull request #20346: [MINOR][SQL] Fix wrong comments on org.apache.spa...

GitHub user dongjoon-hyun opened a pull request:

    https://github.com/apache/spark/pull/20346

    [MINOR][SQL] Fix wrong comments on org.apache.spark.sql.parquet.row.attributes

    ## What changes were proposed in this pull request?
    
    This PR fixes the wrong comment on `org.apache.spark.sql.parquet.row.attributes`
    which is useful for UDT like Vector/Matrix. Please see [SPARK-22320](https://issues.apache.org/jira/browse/SPARK-22320) for the usage. 
    
    Originally, [SPARK-19411](https://github.com/apache/spark/commit/bf493686eb17006727b3ec81849b22f3df68fdef#diff-ee26d4c4be21e92e92a02e9f16dbc285L314) left this behind during removing optional column metadatas. In the same PR, the same comment was removed at line 310-311.
    
    ## How was this patch tested?
    
    N/A (This is about comments).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dongjoon-hyun/spark minor_comment_parquet

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20346.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20346
    
----
commit 4207754cc67633956b80e213875f6f5c3c2c0952
Author: Dongjoon Hyun <do...@...>
Date:   2018-01-22T01:58:48Z

    [MINOR] Fix wrong comments on org.apache.spark.sql.parquet.row.attributes

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20346: [MINOR][SQL] Fix wrong comments on org.apache.spark.sql....

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/20346
  
    cc @viirya 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20346: [MINOR][SQL] Fix wrong comments on org.apache.spark.sql....

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20346
  
    **[Test build #86453 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86453/testReport)** for PR 20346 at commit [`4207754`](https://github.com/apache/spark/commit/4207754cc67633956b80e213875f6f5c3c2c0952).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20346: [MINOR][SQL] Fix wrong comments on org.apache.spark.sql....

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/20346
  
    Merged to master and branch-2.3.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20346: [MINOR][SQL] Fix wrong comments on org.apache.spark.sql....

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20346
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/82/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20346: [MINOR][SQL] Fix wrong comments on org.apache.spark.sql....

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/20346
  
    Thank you for review and confirming, @viirya !


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20346: [MINOR][SQL] Fix wrong comments on org.apache.spark.sql....

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20346
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86453/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #20346: [MINOR][SQL] Fix wrong comments on org.apache.spa...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/20346


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20346: [MINOR][SQL] Fix wrong comments on org.apache.spark.sql....

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/20346
  
    Thank you, @HyukjinKwon and @viirya !


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20346: [MINOR][SQL] Fix wrong comments on org.apache.spark.sql....

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20346
  
    **[Test build #86453 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86453/testReport)** for PR 20346 at commit [`4207754`](https://github.com/apache/spark/commit/4207754cc67633956b80e213875f6f5c3c2c0952).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20346: [MINOR][SQL] Fix wrong comments on org.apache.spark.sql....

Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:

    https://github.com/apache/spark/pull/20346
  
    This is an old code comment we should remove it before. Thanks for fixing
    it. LGTM
    
    
    
    On Jan 22, 2018 11:20 AM, "Dongjoon Hyun" <no...@github.com> wrote:
    
    > cc @viirya <https://github.com/viirya>
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/spark/pull/20346#issuecomment-359307422>, or mute
    > the thread
    > <https://github.com/notifications/unsubscribe-auth/AAEM99hcsTAQVh-D0z8DrdQyIecCn4NEks5tM_CIgaJpZM4RmFEa>
    > .
    >



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20346: [MINOR][SQL] Fix wrong comments on org.apache.spark.sql....

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20346
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20346: [MINOR][SQL] Fix wrong comments on org.apache.spark.sql....

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/20346
  
    Thank you for review and approval, @HyukjinKwon !


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20346: [MINOR][SQL] Fix wrong comments on org.apache.spark.sql....

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20346
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org