[GitHub] [superset] rusackas commented on a diff in pull request #20606: feat(dashboard): Transition to Explore with React Router

[GitBox <gi...@apache.org>]

rusackas commented on code in PR #20606:
URL: https://github.com/apache/superset/pull/20606#discussion_r914919817


##########
superset-frontend/src/dashboard/components/SliceHeader/index.tsx:
##########
@@ -54,6 +62,28 @@ const CrossFilterIcon = styled(Icons.CursorTarget)`
   width: 22px;
 `;
 
+export const getSliceHeaderTooltip = (sliceName: string | undefined) => {
+  if (!isFeatureEnabled(FeatureFlag.DASHBOARD_TO_EXPLORE_SPA)) {
+    return sliceName
+      ? t('Click to edit %s in ', sliceName)

Review Comment:
   ```suggestion
         ? t('Click to edit %s in ', sliceName)
   ```
   Is this missing a word? Edit {sliceName} in...?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org